Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint cleanup quad #610

Merged
merged 25 commits into from
Jan 19, 2022
Merged

Conversation

mmahsereci
Copy link
Contributor

@mmahsereci mmahsereci commented Jan 11, 2022

In a Nutshell

This PR gets rid of some disabled pylint configurations in quad packages. These are

  • else-if-used
  • missing-function-docstring
  • line-too-long
  • missing-raises-doc
  • function-redefined

Detailed Description

n/a

Related Issues

related to #523

@mmahsereci mmahsereci requested a review from a team as a code owner January 11, 2022 19:43
@mmahsereci mmahsereci self-assigned this Jan 11, 2022
@mmahsereci mmahsereci added the quad Issues related to quadrature label Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #610 (35f0d61) into main (3ae7949) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #610   +/-   ##
=======================================
  Coverage   89.39%   89.39%           
=======================================
  Files         181      181           
  Lines        6677     6678    +1     
  Branches     1026     1026           
=======================================
+ Hits         5969     5970    +1     
  Misses        479      479           
  Partials      229      229           
Impacted Files Coverage Δ
...c/probnum/quad/kernel_embeddings/_expquad_gauss.py 100.00% <ø> (ø)
...robnum/quad/kernel_embeddings/_expquad_lebesgue.py 100.00% <ø> (ø)
src/probnum/quad/solvers/bayesian_quadrature.py 86.58% <ø> (ø)
...bnum/quad/solvers/belief_updates/_belief_update.py 96.96% <ø> (ø)
src/probnum/quad/solvers/bq_state.py 100.00% <ø> (ø)
src/probnum/quad/solvers/policies/_policy.py 100.00% <ø> (ø)
...olvers/stopping_criteria/_bq_stopping_criterion.py 100.00% <ø> (ø)
...quad/solvers/stopping_criteria/_rel_mean_change.py 70.00% <ø> (ø)
src/probnum/quad/_bayesquad.py 94.11% <100.00%> (+0.17%) ⬆️
...robnum/quad/kernel_embeddings/_kernel_embedding.py 91.30% <100.00%> (ø)

@mmahsereci mmahsereci marked this pull request as draft January 12, 2022 14:00
@marvinpfoertner marvinpfoertner self-requested a review January 12, 2022 14:08
@marvinpfoertner marvinpfoertner self-assigned this Jan 12, 2022
@mmahsereci
Copy link
Contributor Author

mmahsereci commented Jan 12, 2022

@marvinpfoertner I hope this is somewhat complete for quad. There are 3 pylint messages still disabled but it does not make sense to resolve these now. They are:

@mmahsereci mmahsereci marked this pull request as ready for review January 12, 2022 18:36
src/probnum/quad/_bayesquad.py Outdated Show resolved Hide resolved
src/probnum/quad/_bayesquad.py Outdated Show resolved Hide resolved
src/probnum/quad/_bayesquad.py Outdated Show resolved Hide resolved
src/probnum/quad/_bayesquad.py Outdated Show resolved Hide resolved
src/probnum/quad/solvers/bayesian_quadrature.py Outdated Show resolved Hide resolved
src/probnum/quad/solvers/bayesian_quadrature.py Outdated Show resolved Hide resolved
src/probnum/quad/solvers/bayesian_quadrature.py Outdated Show resolved Hide resolved
src/probnum/quad/solvers/bayesian_quadrature.py Outdated Show resolved Hide resolved
src/probnum/quad/solvers/bayesian_quadrature.py Outdated Show resolved Hide resolved
src/probnum/quad/solvers/bayesian_quadrature.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@marvinpfoertner marvinpfoertner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@mmahsereci mmahsereci merged commit 58c3023 into probabilistic-numerics:main Jan 19, 2022
@mmahsereci mmahsereci deleted the mm-quad-pylint branch January 19, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quad Issues related to quadrature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants