Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor utils with pylint #683

Merged
merged 9 commits into from
Apr 5, 2022
Merged

refactor utils with pylint #683

merged 9 commits into from
Apr 5, 2022

Conversation

akapoor13
Copy link
Contributor

@akapoor13 akapoor13 commented Mar 27, 2022

In a Nutshell

Fix pylint messages in probnum.utils

Detailed Description

Refactors probnum.utils to comply with pylint line-too-long, no-else-return and else-if-used.

Related Issues

Closes #666

@akapoor13 akapoor13 requested review from pnkraemer and a team as code owners March 27, 2022 06:28
@akapoor13 akapoor13 changed the title rector to comply with pylint refactor to comply with pylint Mar 27, 2022
@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #683 (8bb4f86) into main (ae017dd) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #683   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files         192      192           
  Lines        7315     7315           
  Branches     1157     1157           
=======================================
  Hits         6579     6579           
  Misses        491      491           
  Partials      245      245           
Impacted Files Coverage Δ
src/probnum/utils/linalg/_cholesky_updates.py 100.00% <ø> (ø)
src/probnum/utils/linalg/_inner_product.py 88.88% <ø> (ø)
src/probnum/utils/linalg/_orthogonalize.py 90.00% <ø> (ø)
src/probnum/utils/arrayutils.py 37.50% <66.66%> (ø)

Copy link
Collaborator

@pnkraemer pnkraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@akapoor13
Copy link
Contributor Author

failing black CICD pipeline because of ImportError: cannot import name '_unicodefun' from 'click' in black src file

@JonathanWenger
Copy link
Contributor

ImportError: cannot import name '_unicodefun' from 'click'

Possibly related issue: psf/black#2634

@JonathanWenger JonathanWenger added the testing and CI Unit tests, coverage and continuous integration label Mar 28, 2022
@akapoor13 akapoor13 changed the title refactor to comply with pylint refactor utils with pylint Mar 29, 2022
@pnkraemer pnkraemer self-assigned this Mar 31, 2022
@pnkraemer
Copy link
Collaborator

Hex @akapoor13, it seems that due to the other pylint-PRs being merged more quickly than this one, merge conflicts were created. Please ping me once they are resolved and I will make sure to merge the PR swiftly :)

@akapoor13
Copy link
Contributor Author

Hey @pnkraemer think we're good to go now

@pnkraemer pnkraemer merged commit 32299e6 into probabilistic-numerics:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing and CI Unit tests, coverage and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easy-to-fix pylint messages in probnum.utils
3 participants