Fixed the line-too-long message for all modules under probnum.linalg subpackage.
#696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing config in `tox.ini`.
peterw2333
requested review from
JonathanWenger,
marvinpfoertner and
a team
as code owners
JonathanWenger
added
linalg
…nse to the failed pylint checks.
|
@JonathanWenger Could you please approve running the checks again? I have made a new commit in response to the test results stating that maximum line length should be 88, instead of the default of 100 in pylint (as I have wrongly assumed). |
|
I am a bit confused about why the pylint and black checks would give an |
JonathanWenger
requested changes
Apr 5, 2022
…alg-pylint-refactor
src/probnum/linalg/solvers/information_ops/_linear_solver_information_op.py
Outdated
Show resolved
Hide resolved
src/probnum/linalg/solvers/stopping_criteria/_linear_solver_stopping_criterion.py
Outdated
Show resolved
Hide resolved
JonathanWenger
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Nutshell
Fixed the
line-too-longmessage for all modules underprobnum.linalgsubpackage.Detailed Description
Splitted lines longer than 100 characters into multiple lines, each shorter than 100 characters, as required by pylint. Stopped ignoring
line-too-longissue forprobnum.linalgsubpackage by changing configuration intox.ini.Solving each message in different pull requests as requested in #671.
Related Issues
Finishes first to-do in #671.