Update docs based on crate restructuring #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seanmlyons22
commented
May 6, 2024
seanmlyons22
commented
- Install target folder is now probe-rs-tools
- Fixed dead link to default cargo-embed toml
- Associated PR: Update docs based on restructuring probe-rs#2431
* Install target folder is now probe-rs-tools * Fixed dead link to default cargo-embed toml * Associated PR: probe-rs/probe-rs#2431
seanmlyons22
force-pushed
the
fixes-based-on-crate-restructuring
branch
from
5106ea9 to
9f294aa
Compare
bugadani
reviewed
May 6, 2024
bugadani
previously approved these changes
May 16, 2024
bugadani
reviewed
May 22, 2024
|
|
||
| ```sh | ||
| # Build and tag the container image, specifying the name as defined in the `Cross.toml`. | ||
| docker build -t crossimage crossimage/ | ||
|
|
||
| # Run cross to compile, cross arguments are the same as the `cargo` ones | ||
| cross build --release --target=armv7-unknown-linux-gnueabihf --features cli | ||
| cross build --path probe-rs-tools --release --target=armv7-unknown-linux-gnueabihf |
There was a problem hiding this comment.
@Dirbaio I believe you edited this last time. Can you tell me why the path wasn't specified in the old revision (consequently, can you tell me if the new version is correct?)?
There was a problem hiding this comment.
I think we had a default that pointed to probe-rs
There was a problem hiding this comment.
I don't see how that's specified :/
|
@seanmlyons22 sorry for the delay. I've taken the liberty to update the PR with some more changes, I hope you don't mind. @Yatekii I think this should be suffcient for the website part of the new release. |
Yatekii
reviewed
May 22, 2024
Co-authored-by: Noah Hüsser <[email protected]>
Yatekii
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.