Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hovering on sketch name by username doesn't change the background color to logo color in "light" && "dark" mode #2676

Open
PiyushChandra17 opened this issue Dec 3, 2023 · 5 comments · May be fixed by #3408
Open

Hovering on sketch name by username doesn't change the background color to logo color in "light" && "dark" mode #2676

PiyushChandra17 opened this issue Dec 3, 2023 · 5 comments · May be fixed by #3408
Labels
Area:CSS Area: Design

Comments

@PiyushChandra17
Copy link
Contributor

Increasing Access

It will provide better user interface for the client side

Feature enhancement details

Hovering on sketch name by username doesn't change the background color to logo color in "light" && "dark" mode as it's reproducible in "high contrast" mode

username
@PiyushChandra17 PiyushChandra17 mentioned this issue Dec 3, 2023
Closed
4 tasks
@lindapaiste
Copy link
Collaborator

Looks like the contrast theme is getting the yellow hover color from the a:hover style, which uses the theme variable "heavy-text-color". The light and dark themes do have a hover effect but it's way too subtle. I think this has come up before in other places. Like the links on the sign in page? It's definitely related to #2592. We might want to make it so that all links have the "logo-color" as their hover color rather than the "heavy-text-color". Before making that sort of site-wide change we have to look around to make sure that it's an improvement everywhere, but I suspect that it probably is.

@abhinav700
Copy link

@PiyushChandra17 May I work on this issue?

@RishabhLawaniya
Copy link

@PiyushChandra17 I want to work on this enhancement feature, May I?

@Mamatha1718
Copy link

Hi @PiyushChandra17 , This issue is still open, i would like to work on this issue.

@Harshit-7373
Copy link
Contributor

@PiyushChandra17 Can you help me replicate this issue? I am unable to find it.

Harshit-7373 added a commit to Harshit-7373/p5.js-web-editor that referenced this issue Mar 19, 2025
@Harshit-7373
Fix background color issue on hover for sketch name by username proce…
0127000 
…ssing#2676
@Harshit-7373 Harshit-7373 linked a pull request Mar 19, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area:CSS Area: Design
Projects
None yet
Milestone
No milestone
7 participants
@lindapaiste @raclim @PiyushChandra17 @abhinav700 @RishabhLawaniya @Mamatha1718 @Harshit-7373