Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix project owner username hover color #2677

Conversation

PiyushChandra17
Copy link
Contributor

Fixes #2676

Changes:

  • Currently we do not have any styles associated with project owner username
  • Added className to that link
  • Added hover effect
username-hover

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Jan 26, 2024

Thanks for submitting this! I think this is definitely a beneficial change and will need to be updated, but I'm erring towards establishing a design for how all of the links for the editor will look before implementing any changes. I'm going to close this for now and add this to the "Closed PRs Saved for Later Board" to keep it in mind and revisit once the appearance is more finalized.

@PiyushChandra17
Copy link
Contributor Author

Thanks for submitting this! I think this is definitely a beneficial change and will need to be updated, but I'm erring towards establishing a design for how all of the links for the editor will look before implementing any changes. I'm going to close this for now and add this to the "Closed PRs Saved for Later Board" to keep it in mind and revisit once the appearance is more finalized.

@raclim Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants