-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix: Search box doesn't fit in overlays on mobile using MediaQuery
Tag
#2434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lindapaiste please review my PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run this command and push the changes.
git revert 8c8dfa16c4ad9ddb7d9522ee9add70de9d5d6363
That will remove the unrelated changes to CollectionListRow
.
When you start a new branch for a PR you want to start from upstream/develop
and not include the code from your other branches. I know this git stuff can be a real headache.
</header> | ||
<MediaQuery query="(max-width: 767px)"> | ||
{actions && ( | ||
<div className="overlay__actions-mobile">{actions}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so do you want me run git revert 8c8dfa16c4ad9ddb7d9522ee9add70de9d5d6363
and push again..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or else do i need to do any changes?
reverts commit 8c8dfa1.
@lindapaiste hope this will not bother you.. i reverted other branch commit for this.. pushed again. please review it in your freetime and let me know if any other changes required |
Thanks for your work on this! Due to the amount of time that's passed since this pull request was opened, I'm going to close this for now. I'm sorry that we ended up not being able to merge this in, but please feel free to reopen a new pull request for this issue! |
Fixes: #2369
Changes:
I have used
<MediaQuery>
tag to fix the issueI have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123