Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ThemeProvider #2994

Merged
merged 3 commits into from
Feb 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions client/modules/App/components/ThemeProvider.jsx
Original file line number Diff line number Diff line change
@@ -1,23 +1,18 @@
import React from 'react';
import PropTypes from 'prop-types';
import { connect } from 'react-redux';
import { useSelector } from 'react-redux';
import { ThemeProvider } from 'styled-components';
import theme from '../../../theme';

import theme, { Theme } from '../../../theme';

const Provider = ({ children, currentTheme }) => (
<ThemeProvider theme={{ ...theme[currentTheme] }}>{children}</ThemeProvider>
);
const Provider = ({ children }) => {
const currentTheme = useSelector((state) => state.preferences.theme);
return (
<ThemeProvider theme={{ ...theme[currentTheme] }}>{children}</ThemeProvider>
);
};

Provider.propTypes = {
children: PropTypes.node.isRequired,
currentTheme: PropTypes.oneOf(Object.keys(Theme)).isRequired
children: PropTypes.node.isRequired
};

function mapStateToProps(state) {
return {
currentTheme: state.preferences.theme
};
}

export default connect(mapStateToProps)(Provider);
export default Provider;
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from 'react';
import { act, fireEvent, reduxRender, screen } from '../../../../test-utils';
import { initialState } from '../../reducers/preferences';
import Preferences from './index';
import * as PreferencesActions from '../../actions/preferences';

Expand All @@ -15,7 +16,10 @@ describe('<Preferences />', () => {
const subject = (initialPreferences = {}) =>
reduxRender(<Preferences />, {
initialState: {
preferences: initialPreferences
preferences: {
...initialState,
...initialPreferences
}
}
});

Expand Down
2 changes: 1 addition & 1 deletion client/modules/IDE/reducers/preferences.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as ActionTypes from '../../../constants';

const initialState = {
export const initialState = {
fontSize: 18,
autosave: true,
linewrap: true,
Expand Down
16 changes: 2 additions & 14 deletions client/testData/testReduxStore.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { initialState as initialFilesState } from '../modules/IDE/reducers/files';
import { initialState as initialPrefState } from '../modules/IDE/reducers/preferences';

const mockProjects = [
{
Expand Down Expand Up @@ -46,20 +47,7 @@ const initialTestState = {
parentId: undefined
},
files: initialFilesState(),
preferences: {
fontSize: 18,
autosave: true,
linewrap: true,
lineNumbers: true,
lintWarning: false,
textOutput: false,
gridOutput: false,
theme: 'light',
autorefresh: false,
language: 'en-US',
autocloseBracketsQuotes: true,
autocompleteHinter: false
},
preferences: initialPrefState,
user: {
email: 'happydog@example.com',
username: 'happydog',
Expand Down
Loading