Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor console reducers and actions using redux toolkit #3119

Conversation

PiyushChandra17
Copy link
Contributor

Associated issue: #2042

Changes:

  • First things first removed all the associated constants
  • Used createSlice to rewrite the console reducer
  • Exported the automatically generated action creator functions from actions/console.js
  • Deleted the existing action creator function

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Jun 5, 2024

Thanks for your work on this! I'm skimming over this at the moment so I'm sorry that my feedback isn't very specific, but while running this branch I noticed that a few errors pop up when I try to run my sketch.

@PiyushChandra17
Copy link
Contributor Author

Thanks for your work on this! I'm skimming over this at the moment so I'm sorry that my feedback isn't very specific, but while running this branch I noticed that a few errors pop up when I try to run my sketch.

Sure, I'll take a look at this one, and try fixing that few errors, probably push the new changes to this branch super soon!

@PiyushChandra17 PiyushChandra17 force-pushed the piyush/refactor-console-redux-toolkit branch from 61a1ccc to a4cfa46 Compare June 6, 2024 16:49
@PiyushChandra17
Copy link
Contributor Author

@raclim I think i have fixed the errors being popped up while running the sketch, can you please check?

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good for now, thanks for your work on this!

@raclim raclim merged commit 934fb07 into processing:develop Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants