Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor createRedirectWithUserName cleanup version #3147

Merged
merged 2 commits into from
Jun 13, 2024
Merged

refactor createRedirectWithUserName cleanup version #3147

merged 2 commits into from
Jun 13, 2024

Conversation

PiyushChandra17
Copy link
Contributor

Associated issue: #2042

Changes:

  • Used useHistory hook from react-router-dom instead of using global constant
  • More cleanup if condition in useEffect to check if username is true

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

raclim
raclim approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this seems good to me, thanks for your work on this!

@raclim raclim merged commit 99b9463 into processing:develop Jun 13, 2024
1 check passed
@raclim raclim mentioned this pull request Jun 13, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raclim raclim raclim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PiyushChandra17 @raclim