Skip to content

Fix searchbox fit overlays on mobile #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PiyushChandra17
Copy link
Contributor

Fixes #2369

Changes:

  • Added MediaQuery component from 'react-responsive'

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Jun 14, 2024

Thanks for your work on this! Would you be able to provide screenshots showcasing your changes? I think I'm personally having some difficulty recreating the issue!

Screenshot 2024-06-14 at 9 30 23 AM

@PiyushChandra17
Copy link
Contributor Author

@raclim @lindapaiste I think on the latest develop this issue is not fully reproducible, not sure though. Perhaps searchbox partially overlays on small screens but adding padding-left does look good on mobile. Here's screenshots,

before:
before

After:
after

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing this out I think this looks okay to me so far! Any other needed changes can be implemented down the line. Thanks again for your work on this!

@raclim raclim merged commit 6c466cd into processing:develop Jul 3, 2024
3 checks passed
@PiyushChandra17
Copy link
Contributor Author

After testing this out I think this looks okay to me so far! Any other needed changes can be implemented down the line. Thanks again for your work on this!

@raclim Cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search box doesn't fit in overlays on mobile
2 participants