Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor Redux in CollectionList.jsx #3389

Conversation

Harshit-7373
Copy link
Contributor

@Harshit-7373 Harshit-7373 commented Mar 12, 2025

Fixes #2042

Changes:

  1. This PR refactors the CollectionList component to modernize its Redux implementation with React-Redux hooks (useSelector and useDispatch).

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@Harshit-7373 Harshit-7373 changed the title Harshit 7373/solved issue #2042 Refractor Redux in CollectionList.jsx Mar 13, 2025
@raclim
Copy link
Collaborator

raclim commented Mar 13, 2025

Thanks for giving this a shot!

Based on the attached issue, I think this might be an incomplete solution, since the original issue aims to completely refactor the components to use Redux-Toolkit. I think I'm also seeing an error in the current implementation here with adding sketches to the collection. Because of these factors, I'm going to close this for now!

@raclim raclim closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring Redux code: hooks, thunks, and redux-toolkit
2 participants