Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance hover effect on console Clear button #2592 #3397

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Harshit-7373
Copy link
Contributor

@Harshit-7373 Harshit-7373 commented Mar 15, 2025

Fixes #2592

Changes:

  1. Updated the colour of the hover effect for the Clear button in the console in _console.scss file.
  2. The colour is mentioned in the theme file for all the 3 (Light , Dark and High contrast themes).

For Light Mode :
Light mode

For Dark Mode :
Dark mode

For High-Contrast Mode :
High-Contrast Mode

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@Harshit-7373
Copy link
Contributor Author

@raclim , it was discussed in the comment section of the issue that changing only the text color is the best option.

If you want, I can add a smooth transition similar to how it works for different features in the p5.js web editor. Please share your thoughts on this.

@@ -89,7 +89,7 @@
@extend %link;
color: getThemifyVariable('secondary-text-color');
&:hover {
color: getThemifyVariable('heavy-text-color');
color: $p5-light-pink; // Use the pink color directly for hover
Copy link
Collaborator

@raclim raclim Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good with the light and dark themes, but we probably want to use $p5-contrast-yellow instead for the contrast theme. Because we want to adjust the color based on theme, we probably also want to keep using the getThemifyVariable() function as well. Could you adjust this line to get the color based on theming?

Besides this, I think this overall is a step in the right direction!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might also remove the extra comment as well, since it's mostly self-explanatory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raclim I have deleted those Self Explanatory Comments in the updated commit. The updated commit solved the requested change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also found that there is no (p5-contrast-yellow) in the themes section mentioned in the SCSS variables file. There is only (p5-yellow) present, and I made the changes based on that.

@raclim raclim added Area:CSS Area:Accessibility Category for accessibility related features and bugs labels Mar 17, 2025
@Harshit-7373
Copy link
Contributor Author

@raclim I have updated the requested Changes. Please Check them once.

Screenshot 2025-03-18 at 1 38 56 AM Here is an image , That shows that the required changes are shown correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Accessibility Category for accessibility related features and bugs Area:CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insufficient hover effect on console Clear button
2 participants