-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance hover effect on console Clear button #2592 #3397
base: develop
Are you sure you want to change the base?
Enhance hover effect on console Clear button #2592 #3397
Conversation
@raclim , it was discussed in the comment section of the issue that changing only the text color is the best option. If you want, I can add a smooth transition similar to how it works for different features in the p5.js web editor. Please share your thoughts on this. |
@@ -89,7 +89,7 @@ | |||
@extend %link; | |||
color: getThemifyVariable('secondary-text-color'); | |||
&:hover { | |||
color: getThemifyVariable('heavy-text-color'); | |||
color: $p5-light-pink; // Use the pink color directly for hover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good with the light
and dark
themes, but we probably want to use $p5-contrast-yellow
instead for the contrast
theme. Because we want to adjust the color based on theme, we probably also want to keep using the getThemifyVariable()
function as well. Could you adjust this line to get the color based on theming?
Besides this, I think this overall is a step in the right direction!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might also remove the extra comment as well, since it's mostly self-explanatory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raclim I have deleted those Self Explanatory Comments in the updated commit. The updated commit solved the requested change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also found that there is no (p5-contrast-yellow) in the themes section mentioned in the SCSS variables file. There is only (p5-yellow) present, and I made the changes based on that.
@raclim I have updated the requested Changes. Please Check them once. ![]() |
Fixes #2592
Changes:
For Light Mode :

For Dark Mode :

For High-Contrast Mode :

I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123