Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use Title Case for Settings Modal Tab Titles #3421

Merged
merged 2 commits into from
Apr 6, 2025

Conversation

priyanjal1234
Copy link

Fixes #3415

Updated tab titles in the settings modal to follow title case.

Changed from "General settings" → "General Settings".

Copy link

welcome bot commented Mar 26, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link

release-com bot commented Mar 26, 2025

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-71ac0c4a94

@Jatin24062005
Copy link
Contributor

Hey @priyanjal1234 Thanks for the PR! While the title case change is correct, this update is quite minimal and doesn’t significantly impact the editor’s usability or functionality. It might be better to bundle similar UI/UX consistency improvements together rather than submitting a single PR for such a small change. What do you think?

@raclim
Copy link
Collaborator

raclim commented Mar 28, 2025

Thanks for sharing your thoughts @Jatin24062005 and for submitting this fix @priyanjal1234! We're aiming to keep changes minimal and focused on the specific issue at hand to make tracking and merging them easier. Since the attached issue is specifically about title casing, the scope of this PR looks good.

That said, the issue has a "Status: On Hold" label, which means it's not ready to be worked on just yet. Since the work has already been complete, we can keep this PR—but for future reference, please hold off on working on issues marked as "On Hold".

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work on this @priyanjal1234!

@raclim raclim merged commit 3fa5d95 into processing:develop Apr 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings modal should use title case for tab titles
4 participants