Make navbar more accessible (keyboard) #3442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the navbar more accessible by adding key-down event listener on buttons. Now one can navigate menu-items using `up` or `down` arrow-keys.
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
Hello @raclim, |
|
Thanks for your work on this! We do already have an open PR that resolves this issue. Since we're planning to work with that one, I don't think we can get this in. I'm sorry that we're not able to work with this one, but please feel free to check that one out and add any other thoughts you might have! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the navbar more accessible by adding key-down event listener on buttons. Now, one can navigate menu-items using
upordownarrow-keys along withtabandshift-tab.Fixes #2933
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123