Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing-strokeShader() and some minor fixes in shaderHooks-docs #7649

Open
wants to merge 2 commits into
base: dev-2.0
Choose a base branch
from
Open

fixing-strokeShader() and some minor fixes in shaderHooks-docs #7649

wants to merge 2 commits into from

Conversation

perminder-17
Copy link
Contributor

I know we should hold-off on the docs with the shaderHooks but they were very minor so fixing little stuffs.

@perminder-17 perminder-17 changed the title fixing-strokeShader() and some minor fixes in shaderHooks fixing-strokeShader() and some minor fixes in shaderHooks-docs Mar 21, 2025
@perminder-17 perminder-17 marked this pull request as ready for review March 21, 2025 01:07
@perminder-17 perminder-17 requested a review from holomorfo March 21, 2025 02:17
holomorfo
holomorfo approved these changes Mar 22, 2025
View reviewed changes
Copy link

@holomorfo holomorfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets test how it renders maybe we can add also screenshots in the PRs, I'll do the same with mine

@perminder-17 perminder-17 mentioned this pull request Mar 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holomorfo holomorfo holomorfo approved these changes

@davepagurek davepagurek Awaiting requested review from davepagurek

Assignees
No one assigned
Labels
Documentation p5.js 2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@perminder-17 @holomorfo @ksen0 @limzykenneth