GitHub release tag propagated to artifacts from fork #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Stefterv not sure why the PR review is not working - it seems to be a permission issue, but other runs of the workflow don't have this issue. so, I'll try to solve this, but in the meantime appreciate your thoughts on the work. |
|
still not sure what the issue is, but it could be because I'm merging from a fork, and changing the workflow? Will create new PR from branch. |
mingness
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the version is set using a conditional, because one cannot set version from cli directly. This is just one way to solve this - if we move version to be set in a unified properties file, there might be yet another solution