Change install script ot use composer image instead of composer/composer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sripts were not executable before when not using bash shell.
The composer/composer image is outdated and runs on php 7.0.7, while doctrine/instantiator requires ^7.1. The lastest composer image however has php 7.4 installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The composer/composer image is outdated and runs on php 7.0.7, while
doctrine/instantiator requires ^7.1.
The lastest composer image however has php 7.4 installed.
In addition I added some shebangs to the
installandruntestscripts so that I can run them using fish shell.See you tomorrow! :)