Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github-script to generate versioned blobs and commits #1301

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

klutchell
Copy link
Contributor

@klutchell klutchell commented Dec 26, 2024

Resolves 10 code-scanning warnings.

@klutchell klutchell force-pushed the kyle/versioning-scripts branch 2 times, most recently from 612ada1 to 5049b23 Compare December 26, 2024 17:55
@klutchell klutchell changed the title Use github-script to generate versioned blobs and tree Use github-script to generate versioned blobs and commits Dec 26, 2024
@klutchell klutchell force-pushed the kyle/versioning-scripts branch from 5049b23 to 57caecf Compare December 26, 2024 17:58
@klutchell klutchell force-pushed the kyle/versioning-scripts branch from 57caecf to afe761d Compare December 26, 2024 18:05
@klutchell klutchell force-pushed the kyle/versioning-scripts branch from afe761d to 7fa1e3a Compare December 26, 2024 18:14
flowzone.yml Show resolved Hide resolved
flowzone.yml Show resolved Hide resolved
Copy link
Contributor

@pipex pipex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some minor comments, nothing that should hold back the merge.

Don't really know the GitHub API though. Took a quick look at the documentation and what you have seems correct. I assume the PR would not merge otherwise anyway

@klutchell
Copy link
Contributor Author

Testing PR open, sync, and merge here: balena-io-experimental#12

@klutchell
Copy link
Contributor Author

Change-type: patch
Signed-off-by: Kyle Harding <[email protected]>
@klutchell klutchell force-pushed the kyle/versioning-scripts branch from 355e372 to 27aaed5 Compare December 31, 2024 17:18
@klutchell
Copy link
Contributor Author

klutchell commented Dec 31, 2024

Merge workflow looks good, everything is versioned and tagged correctly. I've squashed the commits and it's ready to go!

@pipex
Copy link
Contributor

pipex commented Dec 31, 2024

LGTM

@flowzone-app flowzone-app bot merged commit f4bb25f into master Dec 31, 2024
69 checks passed
@flowzone-app flowzone-app bot deleted the kyle/versioning-scripts branch December 31, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants