Prevent linting jobs from running on PR close events #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Website deployed to CF Pages, 👀 preview link https://59da137c.flowzone.pages.dev |
klutchell
force-pushed
the
kyle/close-events
branch
from
3f055c1 to
d4d3193
Compare
klutchell
force-pushed
the
kyle/close-events
branch
from
d4d3193 to
810b78a
Compare
There is no value in running actionlint or pre-commit checks on PR merge or close events. Same with the Node version checks, no need on close events. The octoscan checks should run on merge to update the main branch code scanning results, but not on PR close. Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/close-events
branch
from
a599a31 to
010eff0
Compare
pipex
reviewed
Jan 17, 2025
flowzone.yml
Outdated
| @@ -1890,12 +1908,18 @@ jobs: | |||
|
|
|||
| # check if the repository has a package.json file and which engine versions are supported | |||
| is_npm: | |||
| name: Check NodeJS versions | |||
| name: request branch for pull requestJS versions | |||
There was a problem hiding this comment.
Suggested change
| name: request branch for pull requestJS versions | |
| name: request branch for pull request JS versions |
There was a problem hiding this comment.
That must have been a copy-paste error, I didn't even mean to update that job name? Weird.
There was a problem hiding this comment.
I thought it was weird too, but I assumed you had some reason? :p
There was a problem hiding this comment.
That's very nice of you
These jobs do not rely on versioned source, so they can default to the pull request HEAD sha and fallback to the github ref for other event types. Using the github ref is not appropriate for pull_request_target events where the ref/sha is always the base branch. Change-type: minor Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/close-events
branch
from
010eff0 to
9fb5218
Compare
|
As intended, octoscan and check nodeJS versions still runs on merge, backed by File List. However linting jobs like pre-commit and actionlint are skipped as planned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent linting jobs from running on PR close events
There is no value in running actionlint or pre-commit checks
on PR merge or close events.
Same with the Node version checks, no need on close events.
The octoscan checks should run on merge to update the main
branch code scanning results, but not on PR close.
Tested close event here.
Note that
File Listruns without failing, so we can leverage it forCustom alwaysjob conditions in a future PR.Use shallow checkout with github token for linting jobs
These jobs do not rely on versioned source, so they
can default to the pull request HEAD sha and fallback
to the github ref for other event types.
Using the github ref is not appropriate for pull_request_target
events where the ref/sha is always the base branch.