Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always publish GitHub releases even without artifacts #799

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

klutchell
Copy link
Collaborator

Change-type: minor

@klutchell
Copy link
Collaborator Author

klutchell commented Nov 10, 2023

@ab77 @Page- your thoughts on this change, any downsides? Perhaps paying to store source artifacts on private repos?

The use case being balena-io/deploy-to-balena-action#104

@ab77
Copy link
Member

ab77 commented Nov 10, 2023

@ab77 @Page- your thoughts on this change, any downsides?

The use case being balena-io/deploy-to-balena-action#104

I think in absence of any files, GH adds the default archive of the commit to the release, so this is fine.

@klutchell klutchell force-pushed the kyle/always-github-release branch from de4c988 to a3cfa1d Compare November 13, 2023 18:05
@klutchell klutchell marked this pull request as ready for review November 13, 2023 18:05
@flowzone-app flowzone-app bot enabled auto-merge November 13, 2023 18:06
@klutchell klutchell requested review from pipex and Page- November 13, 2023 23:36
Change-type: minor
Signed-off-by: Kyle Harding <[email protected]>
@klutchell klutchell force-pushed the kyle/always-github-release branch from a3cfa1d to 4fb48ba Compare November 14, 2023 01:18
@flowzone-app flowzone-app bot merged commit 4d6e484 into master Nov 14, 2023
73 checks passed
@flowzone-app flowzone-app bot deleted the kyle/always-github-release branch November 14, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants