plugins/environments.js: Fix creation of new environments #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command `eslint --fix ./lib/plugins/environments.js` was used to lint the plugin and some variable names were updated to camel case manually. Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/new-environments
branch
from
6b0d187 to
50b6c5f
Compare
Without this change, environments that do not exist will not be created by safe-settings. New tests are included. Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/new-environments
branch
from
50b6c5f to
b5f0802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if environments do not exist in the target repository, they cannot be created
if all properties are not populated.
This PR performs a lint of the environments plugin file (first commit) before adding new
test cases to cover the creation of environments that do not exist.
The command
eslint --fix ./lib/plugins/environments.jswas used to lint the plugin and some variable names were
updated to camel case manually.