Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node filters in cluster config #657

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Support node filters in cluster config #657

merged 1 commit into from
Jan 29, 2022

Conversation

NickBurkard
Copy link
Contributor

@NickBurkard NickBurkard commented Jan 21, 2022

Enables configuration of node filters for Redis cluster client, which was added in Lettuce 6.1.6. Associated issue found here.

Example where config ignores failed & failing nodes:

import io.lettuce.core.cluster.models.partitions.RedisClusterNode.NodeFlag

val clusterConfig = Redis4CatsConfig()
  .withNodeFilter(n => !(n.is(NodeFlag.FAIL) || n.is(NodeFlag.EVENTUAL_FAIL)))

Fixes #655

Copy link
Member

@gvolpe gvolpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And sorry for the delay in getting back to you, looks good to me, though, I don't know much about the clustering part. I trust it's good.

@gvolpe gvolpe merged commit 0d13dd4 into profunktor:series/1.x Jan 29, 2022
@NickBurkard NickBurkard deleted the support-node-filters branch January 29, 2022 15:57
@jhmartin
Copy link

@gvolpe Any chance of getting a release that includes this update?

@gvolpe
Copy link
Member

gvolpe commented Jan 31, 2022

You can use the latest snapshots (these are published on every merge), check out the CI logs: https://github.com/profunktor/redis4cats/runs/4991953320?check_suite_focus=true

@jhmartin
Copy link

@gvolpe True, but it is difficult to pin a dependency version to a specific snapshot version. Any chance of 1.1.0? It looks like there have been quite a few commits since 1.0.0 in June that might benefit from a release as well.

@gvolpe
Copy link
Member

gvolpe commented Feb 1, 2022

See #662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Lettuce 6.1.6 NodeFilter for increased Redis resiliency.
3 participants