Skip to content

Add support for more search engines #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

eat-your-glory
Copy link

Hello! I added support for more search engines. Here are the search engines I added support for:

  • Kagi
  • Startpage
  • Brave Search
  • Qwant
  • Ecosia

@programmer2514
Copy link
Owner

Thank you for the contribution! Unfortunately, many of these engines do not work as intended - please either fix or remove the affected entries.

doesn't work as intended
@eat-your-glory
Copy link
Author

I have removed the Qwant search engine as that was the only one that doesn't work as intended. The only other search engine that you might see doesn't work is Kagi however, Kagi is a paid only search engine so you need to be logged in for it to work. I think Kagi should be included in the search engine list, but I also do think it should be made clear you need to be logged in/its a paid search engine. How should we make that clear?

@@ -39,6 +39,16 @@ function searchRedirect(e) {
search_engine = "https://search.yahoo.com/search?p=";
else if (preferred_engine === "dogpile")
search_engine = "https://www.dogpile.com/serp?q=";
else if (preferred_engine === "kagi")
search_engine = "https://kagi.com/search?q=";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test this search engine - in order to ensure that it works, I am going to need a screenshot of a successful search being made through this engine via FediSearch.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do you one better: I can share the search result link: Search results for "united states" on Kagi

else if (preferred_engine === "startpage")
search_engine = "https://www.startpage.com/sp/search?query=";
else if (preferred_engine === "brave")
search_engine = "https://search.brave.com/search?q=";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one does not seem to properly support advanced search either.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brave Search does seem to work as intended.
image

@programmer2514
Copy link
Owner

As of right now, I am not willing to add a search engine that I cannot test to a project that I maintain. As Kagi is a paid service that I do not plan on subscribing to, I cannot ensure the quality of the search results.

As for the other engines, please see the appropriate review comments. Many of them return results, but not correct/meaningful ones.

Doesn't work as intended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants