Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messages Cluster XML #31656
Messages Cluster XML #31656
Changes from all commits
a069bf4
68de5fb
6e8a0b7
4f99729
8abd979
9eae450
0c81083
856e146
db7ffc6
93cc110
18a556d
3cddfed
196dee0
2cf4cde
cd5ff4c
3074698
8c64f7a
d9e589b
8a94015
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this struct is fabric-scoped in the specification. Is there a specification issue to turn this in non-fabric scoped due to issues including in command or what is the plan here?
Otherwise this must be flagged as such (and we need a fabric_idx as field 254)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/8806