update_cluster_revisions.py: Add possibility to bump cluster revisions to the latest in spec #36456
+294
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
PR #36456: Size comparison from c3b35eb to 53d4c18 Full report (3 builds for cc32xx, stm32)
|
|
PR #36456: Size comparison from c3b35eb to ab056da Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Nov 12, 2024
andy31415
reviewed
Nov 12, 2024
There was a problem hiding this comment.
How is this different from scripts/tools/zap/update_cluster_revisions.py? Is the idea that the other one you say what update you want and this one will automatically update everything to "latest revision"?
There was a problem hiding this comment.
Thanks, Boris. When I wrote this I didn't know we already had a somewhat similar tool. That's great!
From a quick look at the code, that seems to be the difference. This tool bumps all clusters to the latest revision according to the spec.
Another use I see for this tool is to run it in CI to monitor/scan which ZAP files/clusters are outdated and need a rev bump (and how far behind they are from the spec).
I could also move this code into scripts/tools/zap/update_cluster_revisions.py if it makes more sense.
There was a problem hiding this comment.
I honestly don't have strong opinions on where the functionality should live, though having the existing script be able to just take some value for "latest" might be nice, and then people can just keep using it.
There was a problem hiding this comment.
I moved everything into update_cluster_revisions.py and added a readme file with examples.
Now, if you omit --new-revision, it will assume latest revision according to the spec. If you want to give it a try, you can run:
./scripts/tools/zap/update_cluster_revisions.py --dry-run --no-parallel
And you should see it print all of the outdated clusters:
Checking for outdated cluster revisions on: examples/light-switch-app/light-switch-common/icd-lit-light-switch-app.zap
6 found!
Endpoint: 0 cluster_code: 0x28 cluster_revision: 3 cluster_spec_revision: 4 name: Basic Information
Endpoint: 0 cluster_code: 0x30 cluster_revision: 1 cluster_spec_revision: 2 name: General Commissioning
Endpoint: 0 cluster_code: 0x31 cluster_revision: 1 cluster_spec_revision: 2 name: Network Commissioning
Endpoint: 0 cluster_code: 0x35 cluster_revision: 2 cluster_spec_revision: 3 name: Thread Network Diagnostics
Endpoint: 1 cluster_code: 0x3 cluster_revision: 4 cluster_spec_revision: 5 name: Identify
Endpoint: 2 cluster_code: 0x3 cluster_revision: 2 cluster_spec_revision: 5 name: Identify
Checking for outdated cluster revisions on: examples/light-switch-app/light-switch-common/light-switch-app.zap
6 found!
Endpoint: 0 cluster_code: 0x28 cluster_revision: 3 cluster_spec_revision: 4 name: Basic Information
Endpoint: 0 cluster_code: 0x30 cluster_revision: 1 cluster_spec_revision: 2 name: General Commissioning
Endpoint: 0 cluster_code: 0x31 cluster_revision: 1 cluster_spec_revision: 2 name: Network Commissioning
Endpoint: 0 cluster_code: 0x35 cluster_revision: 2 cluster_spec_revision: 3 name: Thread Network Diagnostics
Endpoint: 1 cluster_code: 0x3 cluster_revision: 4 cluster_spec_revision: 5 name: Identify
Endpoint: 2 cluster_code: 0x3 cluster_revision: 2 cluster_spec_revision: 5 name: Identify
Checking for outdated cluster revisions on: examples/light-switch-app/qpg/zap/switch.zap
7 found!
Endpoint: 0 cluster_code: 0x28 cluster_revision: 3 cluster_spec_revision: 4 name: Basic Information
Endpoint: 0 cluster_code: 0x2f cluster_revision: 1 cluster_spec_revision: 3 name: Power Source
Endpoint: 0 cluster_code: 0x30 cluster_revision: 1 cluster_spec_revision: 2 name: General Commissioning
Endpoint: 0 cluster_code: 0x31 cluster_revision: 1 cluster_spec_revision: 2 name: Network Commissioning
Endpoint: 0 cluster_code: 0x35 cluster_revision: 2 cluster_spec_revision: 3 name: Thread Network Diagnostics
Endpoint: 1 cluster_code: 0x3 cluster_revision: 4 cluster_spec_revision: 5 name: Identify
Endpoint: 2 cluster_code: 0x3 cluster_revision: 4 cluster_spec_revision: 5 name: Identify
Checking for outdated cluster revisions on: src/controller/data_model/controller-clusters.zap
0 found!
soares-sergio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
update_cluster_revisions.pytool to bump the cluster revisions to the latest according to the spec if no--new-revisionis provided.I've also added documentation in
README.mdon how to use the tool and expected output examples.