Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming prior to the delivery of the work about "NFC Commissioning". #36555

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Renaming prior to the delivery of the work about "NFC Commissioning". #36555

wants to merge 4 commits into from
+196 −196

Commits on Nov 19, 2024

  1. Renaming prior to the delivery of the work about "NFC Commissioning". 

    In current code, "NFC Commissioning" was used for Onboarding data put into an NFC Tag.
This naming will create confusion with the new "NFC Commissioning" feature
where NFC is used for all the first phase of the commissioning.

We propose to use the folllowing names:
- "NFC onboarding" when an NFC Tag is used to store the onboarding data
(as an alternate solution to QRCode)
- "NFC commissioning" when an NFC Tag is used to perform the first commissioning phase
(as an alternate solution to BLE)

Defines, variables and files have been renamed to reflect this.
The following renaming have been done:
- CHIP_DEVICE_CONFIG_ENABLE_NFC -> CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING
- CONFIG_CHIP_NFC_COMMISSIONING -> CONFIG_CHIP_NFC_ONBOARDING
- chip_enable_nfc -> chip_enable_nfc_onboarding
- NFCManager -> NFCOnboardingManager
- NFCManagerImpl -> NFCOnboardingManagerImpl
- NFCMgr -> NFCOnboardingMgr
- NFCMgrImpl -> NFCOnboardingMgrImpl

The following files have been renamed for the platforms Zephyr, nrfconnect, nxp/k32w0 and telink:
NFCManagerImpl.cpp -> NFCOnboardingManagerImpl.cpp
NFCManagerImpl.h -> NFCOnboardingManagerImpl.h
NFCManager.h -> NFCOnboardingManager.h
    @OlivierGre
    OlivierGre committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5d1bf31 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into nfc_commissioning_chiptool_2024_11_19

    @OlivierGre
    OlivierGre authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8ce9992 View commit details
    Browse the repository at this point in the history

  3. Restyled by clang-format

    @restyled-commits @OlivierGre
    restyled-commits authored and OlivierGre committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0edc799 View commit details
    Browse the repository at this point in the history

  4. Restyled by prettier-markdown

    @restyled-commits @OlivierGre
    restyled-commits authored and OlivierGre committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4f46422 View commit details
    Browse the repository at this point in the history