Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fabric-Sync]: Convert ember-driven functions to interface functions #36659

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fabric-Sync]: Convert ember-driven functions to interface functions #36659

wants to merge 1 commit into from

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Nov 27, 2024 •
edited
Loading

Decouple Commissioner Control Cluster from ember and migrate to use CHI (CommandHandlerInterface) instead

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

PR #36659: Size comparison from 63bc8a3 to b3e1b82

Full report (5 builds for cc32xx, qpg, stm32)
platform target config section 63bc8a3 b3e1b82 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 629454 629454 0 0.0
RAM 205792 205792 0 0.0
lock CC3235SF_LAUNCHXL FLASH 668034 668034 0 0.0
RAM 205936 205936 0 0.0
qpg lighting-app qpg6105+debug FLASH 662928 662928 0 0.0
RAM 105384 105384 0 0.0
lock-app qpg6105+debug FLASH 620764 620764 0 0.0
RAM 99844 99844 0 0.0
stm32 light STM32WB5MM-DK FLASH 483708 483708 0 0.0
RAM 144848 144848 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

PR #36659: Size comparison from 481270d to 3618ebb

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 481270d 3618ebb change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1350998 1350998 0 0.0
RAM 104088 104088 0 0.0
bl702 lighting-app bl702+eth FLASH 650314 650314 0 0.0
RAM 25329 25329 0 0.0
bl702+wifi FLASH 827898 827898 0 0.0
RAM 14069 14069 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056092 1056092 0 0.0
RAM 23917 23917 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 977466 977466 0 0.0
RAM 16556 16556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838600 838600 0 0.0
RAM 123640 123640 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824284 824284 0 0.0
RAM 125520 125520 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771008 771008 0 0.0
RAM 113988 113988 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755212 755212 0 0.0
RAM 114204 114204 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 629454 629454 0 0.0
RAM 205792 205792 0 0.0
lock CC3235SF_LAUNCHXL FLASH 668034 668034 0 0.0
RAM 205936 205936 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 680225 680225 0 0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 700077 700077 0 0.0
RAM 81332 81332 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 700077 700077 0 0.0
RAM 81332 81332 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 657013 657013 0 0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616841 616841 0 0.0
RAM 71652 71652 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636469 636469 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636469 636469 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 636297 636297 0 0.0
RAM 74700 74700 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 656013 656013 0 0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 656013 656013 0 0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612789 612789 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 632641 632641 0 0.0
RAM 71420 71420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 632641 632641 0 0.0
RAM 71420 71420 0 0.0
efr32 lock-app BRD4187C FLASH 931548 931548 0 0.0
RAM 160168 160168 0 0.0
BRD4338a FLASH 744472 744464 -8 -0.0
RAM 233296 233296 0 0.0
window-app BRD4187C FLASH 1023560 1023552 -8 -0.0
RAM 128268 128268 0 0.0
esp32 all-clusters-app c3devkit DRAM 95344 95344 0 0.0
FLASH 1542110 1542110 0 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116256 116256 0 0.0
FLASH 1549186 1549186 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2707099 2707099 0 0.0
RAM 129656 129656 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5998842 5998842 0 0.0
RAM 523400 523400 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5336648 5336648 0 0.0
RAM 242456 242456 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4676176 4676176 0 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12839402 12839402 0 0.0
RAM 582218 582218 0 0.0
chip-tool-ipv6only arm64 unknown 21304 21304 0 0.0
FLASH 10973728 10973728 0 0.0
RAM 633168 633168 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11243367 11243367 0 0.0
RAM 582562 582562 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4500432 4501866 1434 0.0
RAM 205376 205440 64 0.0
fabric-sync debug unknown 4904 4904 0 0.0
FLASH 5596389 5597877 1488 0.0
RAM 472360 472424 64 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5612689 5612689 0 0.0
RAM 228600 228600 0 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4725562 4725562 0 0.0
RAM 204616 204616 0 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4351100 4351100 0 0.0
RAM 198288 198288 0 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4489470 4489470 0 0.0
RAM 202872 202872 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3021933 3021933 0 0.0
RAM 160328 160328 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4096896 4096896 0 0.0
RAM 243000 243000 0 0.0
tv-app debug unknown 5672 5672 0 0.0
FLASH 5949173 5949173 0 0.0
RAM 595888 595888 0 0.0
tv-casting-app debug unknown 5240 5240 0 0.0
FLASH 11040845 11040845 0 0.0
RAM 691992 691992 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916616 916616 0 0.0
RAM 143292 143292 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888720 888720 0 0.0
RAM 141479 141479 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 850632 850632 0 0.0
RAM 142200 142200 0 0.0
nxp contact k32w0+release FLASH 584448 584448 0 0.0
RAM 71056 71056 0 0.0
mcxw71+release FLASH 598992 598992 0 0.0
RAM 63152 63152 0 0.0
light k32w0+release FLASH 611388 611388 0 0.0
RAM 70448 70448 0 0.0
k32w1+release FLASH 685504 685504 0 0.0
RAM 48776 48776 0 0.0
lock mcxw71+release FLASH 761760 761760 0 0.0
RAM 70540 70540 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1644716 1644716 0 0.0
RAM 212072 212072 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552492 1552492 0 0.0
RAM 208872 208872 0 0.0
light cy8ckit_062s2_43012 FLASH 1467724 1467724 0 0.0
RAM 200856 200856 0 0.0
lock cy8ckit_062s2_43012 FLASH 1465580 1465580 0 0.0
RAM 225216 225216 0 0.0
qpg lighting-app qpg6105+debug FLASH 662928 662928 0 0.0
RAM 105384 105384 0 0.0
lock-app qpg6105+debug FLASH 620764 620764 0 0.0
RAM 99844 99844 0 0.0
stm32 light STM32WB5MM-DK FLASH 483708 483708 0 0.0
RAM 144848 144848 0 0.0
telink bridge-app tlsr9258a FLASH 681716 681716 0 0.0
RAM 91200 91200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622122 622122 0 0.0
RAM 31432 31432 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 763288 763288 0 0.0
RAM 50208 50208 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709286 709286 0 0.0
RAM 73460 73460 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626320 626320 0 0.0
RAM 142132 142132 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 812228 812228 0 0.0
RAM 99676 99676 0 0.0
tizen all-clusters-app arm unknown 4976 4976 0 0.0
FLASH 1727572 1727572 0 0.0
RAM 90648 90648 0 0.0
chip-tool-ubsan arm unknown 10788 10788 0 0.0
FLASH 17952350 17952350 0 0.0
RAM 7831780 7831780 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app examples review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yufengwangca