Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp32: remove esp32_codegen.cmake and use common chip_data_model.cmake instead #36674

Merged
merged 1 commit into from
Nov 29, 2024
Merged

esp32: remove esp32_codegen.cmake and use common chip_data_model.cmake instead #36674

merged 1 commit into from
Nov 29, 2024

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Nov 29, 2024

We should remove the custom code generation logic for esp32 and use common chip_data_model.cmake instead

Fixes task2 of #36666

@wqx6 wqx6 requested a review from a team as a code owner November 29, 2024 06:49
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions github-actions bot added documentation Improvements or additions to documentation examples gn labels Nov 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

PR #36674: Size comparison from b3e074c to 0680bc7

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section b3e074c 0680bc7 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1351196 1351196 0 0.0
RAM 104088 104088 0 0.0
bl702 lighting-app bl702+eth FLASH 650480 650480 0 0.0
RAM 25329 25329 0 0.0
bl702+wifi FLASH 828064 828064 0 0.0
RAM 14069 14069 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056258 1056258 0 0.0
RAM 23917 23917 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 977632 977632 0 0.0
RAM 16556 16556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838792 838792 0 0.0
RAM 123640 123640 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824460 824460 0 0.0
RAM 125520 125520 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771200 771200 0 0.0
RAM 113988 113988 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755388 755388 0 0.0
RAM 114204 114204 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 629462 629462 0 0.0
RAM 205792 205792 0 0.0
lock CC3235SF_LAUNCHXL FLASH 668042 668042 0 0.0
RAM 205936 205936 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 680473 680473 0 0.0
RAM 78700 78700 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 700317 700317 0 0.0
RAM 81340 81340 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 700317 700317 0 0.0
RAM 81340 81340 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 657261 657261 0 0.0
RAM 73768 73768 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 617153 617153 0 0.0
RAM 71684 71684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636781 636781 0 0.0
RAM 74228 74228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636781 636781 0 0.0
RAM 74228 74228 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 636545 636545 0 0.0
RAM 74700 74700 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 656253 656253 0 0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 656253 656253 0 0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613021 613021 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 632873 632873 0 0.0
RAM 71420 71420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 632873 632873 0 0.0
RAM 71420 71420 0 0.0
efr32 lock-app BRD4187C FLASH 931292 931292 0 0.0
RAM 160168 160168 0 0.0
BRD4338a FLASH 744680 744672 -8 -0.0
RAM 233296 233296 0 0.0
window-app BRD4187C FLASH 1023240 1023232 -8 -0.0
RAM 128268 128268 0 0.0
esp32 all-clusters-app c3devkit DRAM 95344 95328 -16 -0.0
FLASH 1542118 1542136 18 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116272 116280 8 0.0
FLASH 1549254 1549018 -236 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2707457 2707457 0 0.0
RAM 129656 129656 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5999134 5999134 0 0.0
RAM 523400 523400 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5336942 5336942 0 0.0
RAM 242456 242456 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4676470 4676470 0 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12839426 12839426 0 0.0
RAM 582218 582218 0 0.0
chip-tool-ipv6only arm64 unknown 21304 21304 0 0.0
FLASH 10973744 10973744 0 0.0
RAM 633168 633168 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11243391 11243391 0 0.0
RAM 582562 582562 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4500726 4500726 0 0.0
RAM 205376 205376 0 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5597429 5597429 0 0.0
RAM 472360 472360 0 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5612977 5612977 0 0.0
RAM 228600 228600 0 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4725856 4725856 0 0.0
RAM 204616 204616 0 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4351578 4351578 0 0.0
RAM 198288 198288 0 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4490620 4490620 0 0.0
RAM 202872 202872 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3022061 3022061 0 0.0
RAM 160328 160328 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4097104 4097104 0 0.0
RAM 243000 243000 0 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5950229 5950229 0 0.0
RAM 595888 595888 0 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11046669 11046669 0 0.0
RAM 691992 691992 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916624 916624 0 0.0
RAM 143292 143292 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888836 888836 0 0.0
RAM 141479 141479 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 850788 850788 0 0.0
RAM 142200 142200 0 0.0
nxp contact k32w0+release FLASH 584608 584608 0 0.0
RAM 71056 71056 0 0.0
mcxw71+release FLASH 599144 599144 0 0.0
RAM 63152 63152 0 0.0
light k32w0+release FLASH 611548 611548 0 0.0
RAM 70448 70448 0 0.0
k32w1+release FLASH 685696 685696 0 0.0
RAM 48776 48776 0 0.0
lock mcxw71+release FLASH 762016 762016 0 0.0
RAM 70812 70812 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1644716 1644716 0 0.0
RAM 212072 212072 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552508 1552508 0 0.0
RAM 208872 208872 0 0.0
light cy8ckit_062s2_43012 FLASH 1467740 1467740 0 0.0
RAM 200856 200856 0 0.0
lock cy8ckit_062s2_43012 FLASH 1465596 1465596 0 0.0
RAM 225216 225216 0 0.0
qpg lighting-app qpg6105+debug FLASH 663080 663080 0 0.0
RAM 105384 105384 0 0.0
lock-app qpg6105+debug FLASH 620908 620908 0 0.0
RAM 99844 99844 0 0.0
stm32 light STM32WB5MM-DK FLASH 483716 483716 0 0.0
RAM 144848 144848 0 0.0
telink bridge-app tlsr9258a FLASH 681724 681724 0 0.0
RAM 91200 91200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622130 622130 0 0.0
RAM 31432 31432 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 763488 763488 0 0.0
RAM 50212 50212 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709554 709554 0 0.0
RAM 73496 73496 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626508 626508 0 0.0
RAM 142132 142132 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 812416 812416 0 0.0
RAM 99676 99676 0 0.0
tizen all-clusters-app arm unknown 4976 4976 0 0.0
FLASH 1727728 1727728 0 0.0
RAM 90648 90648 0 0.0
chip-tool-ubsan arm unknown 10788 10788 0 0.0
FLASH 17952454 17952454 0 0.0
RAM 7831832 7831832 0 0.0

@mergify mergify bot merged commit d37eae1 into project-chip:master Nov 29, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrishi dhrishi dhrishi approved these changes

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation examples gn review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wqx6 @andy31415 @dhrishi