Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICD] Re-activate subscription when receiving check-in message if subscription fails and resub is scheduled #37481

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[ICD] Re-activate subscription when receiving check-in message if subscription fails and resub is scheduled #37481

wants to merge 2 commits into from
+15 −5

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Feb 8, 2025 •
edited
Loading

Assume read client fails for subscription because of various timeout via SendAutoResubscribeRequest API with ScopedNodeId and goes to resubscribe with back-off algorithm, once the device becomes active, controller receives the corresponding check-in message, client's scheduled subscription cannot be re-activated immediately. Intuitively, it is better that a resubscription can be triggered immediately

Proposed Resolution:
Re-activate subscription when receiving check-in message if subscription fails and resub is scheduled

Testing

Drafting

@yunhanw-google yunhanw-google requested a review from a team as a code owner February 8, 2025 04:39
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Feb 8, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  examples/chip-tool/commands/clusters/ModelCommand.cpp Unsupported file format
  examples/chip-tool/commands/clusters/ModelCommand.h Unsupported file format
  examples/chip-tool/commands/clusters/ReportCommand.h Unsupported file format
  examples/chip-tool/commands/icd/ICDCommand.cpp Unsupported file format
  examples/fabric-admin/commands/clusters/ModelCommand.cpp Unsupported file format
  examples/fabric-admin/commands/clusters/ModelCommand.h Unsupported file format
  examples/fabric-admin/commands/clusters/ReportCommand.h Unsupported file format
  examples/tv-casting-app/tv-casting-common/commands/clusters/ModelCommand.cpp Unsupported file format
  src/app/InteractionModelEngine.cpp Unsupported file format
  src/app/InteractionModelEngine.h Unsupported file format
  src/app/ReadClient.cpp Unsupported file format
  src/app/ReadClient.h Unsupported file format
  src/app/ReadPrepareParams.h Unsupported file format
  src/app/tests/suites/commands/interaction_model/InteractionModel.cpp Unsupported file format
  src/app/tests/suites/commands/interaction_model/InteractionModel.h Unsupported file format
  src/controller/java/AndroidInteractionClient.cpp Unsupported file format
  src/controller/java/AndroidInteractionClient.h Unsupported file format
  src/controller/java/CHIPInteractionClient-JNI.cpp Unsupported file format
  src/controller/java/MatterInteractionClient-JNI.cpp Unsupported file format
  src/controller/java/src/chip/devicecontroller/ChipDeviceController.java  0% smaller
  src/controller/java/src/matter/controller/MatterControllerImpl.kt Unsupported file format
  src/controller/tests/data_model/TestRead.cpp Unsupported file format

@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch 2 times, most recently from 5423fec to 84eeb84 Compare February 8, 2025 06:35
@yunhanw-google yunhanw-google changed the title [ICD] Close with CHIP_ERROR_LIT_SUBSCRIBE_INACTIVE_TIMEOUT if OnResponseTimeout happens during subscription priming stage [ICD] Close with CHIP_ERROR_LIT_SUBSCRIBE_INACTIVE_TIMEOUT if OnResponseTimeout happens after sending first subscription request Feb 8, 2025
@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch from 84eeb84 to 0a45f2b Compare February 8, 2025 07:49
@yunhanw-google yunhanw-google changed the title [ICD] Close with CHIP_ERROR_LIT_SUBSCRIBE_INACTIVE_TIMEOUT if OnResponseTimeout happens after sending first subscription request [ICD] Activate subscription when receiving check-in message if subscription client stuck in initialized state. Feb 8, 2025
@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch from 0a45f2b to 64037cc Compare February 8, 2025 08:07
@yunhanw-google yunhanw-google changed the title [ICD] Activate subscription when receiving check-in message if subscription client stuck in initialized state. [ICD] Re-activate subscription when receiving check-in message if subscription client stuck in initialized state. Feb 8, 2025
@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch 2 times, most recently from 17bb029 to 82d1fda Compare February 8, 2025 08:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025

PR #37481: Size comparison from ed1babf to 82d1fda

Full report (1 build for stm32)
platform target config section ed1babf 82d1fda change % change
stm32 light STM32WB5MM-DK FLASH 483024 483040 16 0.0
RAM 144688 144688 0 0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch from 82d1fda to c770997 Compare February 13, 2025 02:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

PR #37481: Size comparison from 92f9f0b to c770997

Full report (10 builds for cc32xx, nrfconnect, qpg, stm32, tizen)
platform target config section 92f9f0b c770997 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538894 538966 72 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572766 572838 72 0.0
RAM 205360 205360 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907464 907424 -40 -0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901920 901940 20 0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846084 846084 0 0.0
RAM 141339 141339 0 0.0
qpg lighting-app qpg6105+debug FLASH 662340 662388 48 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 620136 620176 40 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459736 459776 40 0.0
RAM 141568 141568 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1751708 1751692 -16 -0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18683110 18683214 104 0.0
RAM 8181084 8181140 56 0.0

@yunhanw-google yunhanw-google changed the title [ICD] Re-activate subscription when receiving check-in message if subscription client stuck in initialized state. [ICD] Re-activate subscription when receiving check-in message if subscription timeouts and schedule a subscription Feb 13, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

PR #37481: Size comparison from 92f9f0b to a103e4f

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 92f9f0b a103e4f change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1095960 1096004 44 0.0
RAM 94906 94906 0 0.0
bl702 lighting-app bl702+eth FLASH 652080 652124 44 0.0
RAM 33633 33633 0 0.0
bl702+wifi FLASH 828572 828616 44 0.0
RAM 22341 22341 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061718 1061762 44 0.0
RAM 32285 32285 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892592 892636 44 0.0
RAM 26912 26912 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975962 976006 44 0.0
RAM 24752 24752 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815204 815212 8 0.0
RAM 120352 120352 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823832 823840 8 0.0
RAM 125360 125360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770992 771064 72 0.0
RAM 113820 113820 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755260 755332 72 0.0
RAM 114028 114028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538894 538966 72 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572766 572838 72 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 656501 656565 64 0.0
RAM 75420 75420 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 676361 676425 64 0.0
RAM 78060 78060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 676361 676425 64 0.0
RAM 78060 78060 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 633285 633349 64 0.0
RAM 70488 70488 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616117 616093 -24 -0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635753 635729 -24 -0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635753 635729 -24 -0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635621 635693 72 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655337 655409 72 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655337 655409 72 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611969 612033 64 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631829 631893 64 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631829 631893 64 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 937264 937304 40 0.0
RAM 159908 159908 0 0.0
BRD4338a FLASH 730592 730648 56 0.0
RAM 234720 234720 0 0.0
window-app BRD4187C FLASH 1029856 1029928 72 0.0
RAM 128012 128012 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1581680 1581632 -48 -0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1549606 1549554 -52 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2708747 2708451 -296 -0.0
RAM 132784 132784 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5975210 5975054 -156 -0.0
RAM 531600 531600 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5322754 5322458 -296 -0.0
RAM 242712 242712 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4681398 4681102 -296 -0.0
RAM 221448 221448 0 0.0
chip-tool debug unknown 6120 6120 0 0.0
FLASH 13098960 13098804 -156 -0.0
RAM 596578 596578 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11162224 11162064 -160 -0.0
RAM 648256 648256 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11387977 11387821 -156 -0.0
RAM 596362 596362 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4506720 4506424 -296 -0.0
RAM 208632 208632 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5612965 5612821 -144 -0.0
RAM 483504 483504 0 0.0
lighting-app debug+rpc+ui unknown 6152 6152 0 0.0
FLASH 5484513 5484513 0 0.0
RAM 225392 225392 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4730794 4730498 -296 -0.0
RAM 207696 207696 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4359828 4359532 -296 -0.0
RAM 201336 201336 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4497204 4496908 -296 -0.0
RAM 205920 205920 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3005468 3005276 -192 -0.0
RAM 160552 160552 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4096488 4096312 -176 -0.0
RAM 246024 246024 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5951893 5951733 -160 -0.0
RAM 606904 606904 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11271725 11271565 -160 -0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907464 907424 -40 -0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901920 901940 20 0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846084 846084 0 0.0
RAM 141339 141339 0 0.0
nxp contact k32w0+release FLASH 584752 584752 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600208 600280 72 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611076 611076 0 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685512 685576 64 0.0
RAM 48680 48680 0 0.0
lock mcxw71+release FLASH 749024 749096 72 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646756 1646748 -8 -0.0
RAM 211576 211576 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553524 1553596 72 0.0
RAM 208392 208392 0 0.0
light cy8ckit_062s2_43012 FLASH 1439196 1439268 72 0.0
RAM 197144 197144 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467412 1467484 72 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662340 662388 48 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 620136 620176 40 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459736 459776 40 0.0
RAM 141568 141568 0 0.0
telink bridge-app tl7218x FLASH 665226 665232 6 0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621908 621914 6 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745418 745420 2 0.0
RAM 40496 40496 0 0.0
tl7218x FLASH 753974 753980 6 0.0
RAM 97632 97632 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680678 680688 10 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709240 709250 10 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600796 600802 6 0.0
RAM 138912 138912 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 788928 788934 6 0.0
RAM 96488 96488 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1751708 1751692 -16 -0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18683110 18683214 104 0.0
RAM 8181084 8181140 56 0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch from a103e4f to a4a3c11 Compare February 19, 2025 21:53
@github-actions github-actions bot added the lib label Feb 19, 2025
@github-actions github-actions bot added the core label Feb 19, 2025
@yunhanw-google yunhanw-google changed the title [ICD] Re-activate subscription when receiving check-in message if subscription timeouts and schedule a subscription [ICD] Re-activate subscription when receiving check-in message if subscription fails to establish in autoResubscription flow Feb 19, 2025
@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch 3 times, most recently from 265f19d to 577651c Compare February 19, 2025 22:27
@github-actions GitHub Actions
Copy link

PR #37481: Size comparison from 35fda6d to 577651c

Full report (3 builds for cc32xx, stm32)
platform target config section 35fda6d 577651c change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538730 538874 144 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572886 573030 144 0.0
RAM 205360 205360 0 0.0
stm32 light STM32WB5MM-DK FLASH 459776 459880 104 0.0
RAM 141472 141472 0 0.0

bzbarsky-apple
bzbarsky-apple requested changes Feb 21, 2025
View reviewed changes
@yunhanw-google yunhanw-google changed the title [ICD] Re-activate subscription when receiving check-in message if subscription fails to establish in autoResubscription flow [ICD] Re-activate subscription when receiving check-in message if subscription or case timeouts Feb 24, 2025
@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch 2 times, most recently from 10401d7 to 32f226c Compare February 24, 2025 19:41
@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch from 32f226c to 3d53d30 Compare February 25, 2025 06:29
@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch 2 times, most recently from 37f08b6 to f69f04e Compare February 26, 2025 06:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

PR #37481: Size comparison from 629fea4 to f69f04e

Full report (55 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 629fea4 f69f04e change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1096628 1096900 272 0.0
RAM 94842 94842 0 0.0
bl702 lighting-app bl702+eth FLASH 651606 651878 272 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 828878 829150 272 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061274 1061546 272 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892118 892390 272 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975014 975286 272 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815300 815452 152 0.0
RAM 120256 120256 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824220 824372 152 0.0
RAM 125352 125352 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771080 771344 264 0.0
RAM 113724 113724 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755364 755628 264 0.0
RAM 113932 113932 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538842 539122 280 0.1
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572998 573278 280 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 656429 656701 272 0.0
RAM 75324 75324 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 676289 676561 272 0.0
RAM 77964 77964 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 676289 676561 272 0.0
RAM 77964 77964 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 633213 633485 272 0.0
RAM 70392 70392 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616293 616573 280 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635929 636209 280 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635929 636209 280 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635789 636077 288 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655513 655801 288 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655513 655801 288 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612137 612417 280 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631997 632277 280 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631997 632277 280 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 939536 939776 240 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 732536 732880 344 0.0
RAM 234828 234828 0 0.0
window-app BRD4187C FLASH 1032000 1032328 328 0.0
RAM 128024 128024 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1582004 1582262 258 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116108 116108 0 0.0
FLASH 1550014 1550302 288 0.0
IRAM 117039 117039 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907708 907952 244 0.0
RAM 142323 142323 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901788 901876 88 0.0
RAM 124663 124663 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846312 846312 0 0.0
RAM 141251 141251 0 0.0
nxp contact k32w0+release FLASH 585256 585368 112 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600712 600984 272 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611196 611340 144 0.0
RAM 70164 70164 0 0.0
k32w1+release FLASH 685680 685944 264 0.0
RAM 48584 48584 0 0.0
lock mcxw71+release FLASH 749536 749800 264 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646188 1646548 360 0.0
RAM 211472 211472 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552956 1553300 344 0.0
RAM 208288 208288 0 0.0
light cy8ckit_062s2_43012 FLASH 1438644 1438988 344 0.0
RAM 197040 197040 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467516 1467876 360 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662188 662436 248 0.0
RAM 105116 105116 0 0.0
lock-app qpg6105+debug FLASH 620304 620544 240 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459832 460072 240 0.1
RAM 141472 141472 0 0.0
telink bridge-app tl7218x FLASH 665034 665178 144 0.0
RAM 90728 90728 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622078 622222 144 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745218 745340 122 0.0
RAM 40396 40396 0 0.0
tl7218x FLASH 753780 753924 144 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680850 680994 144 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709412 709556 144 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600592 600736 144 0.0
RAM 138812 138812 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 788820 788964 144 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1751016 1751636 620 0.0
RAM 93260 93260 0 0.0
chip-tool-ubsan arm unknown 11492 11492 0 0.0
FLASH 18983694 18985022 1328 0.0
RAM 8306240 8306616 376 0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch from f69f04e to 5c1cc94 Compare February 26, 2025 18:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

PR #37481: Size comparison from 3c9c7e6 to 7d22fe5

Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 3c9c7e6 7d22fe5 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1096892 1097164 272 0.0
RAM 94842 94842 0 0.0
bl702 lighting-app bl702+eth FLASH 651870 652142 272 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 829142 829414 272 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061538 1061810 272 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892382 892654 272 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975278 975550 272 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 817152 817304 152 0.0
RAM 120272 120272 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 826072 826224 152 0.0
RAM 125368 125368 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772956 773220 264 0.0
RAM 113740 113740 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 757240 757504 264 0.0
RAM 113948 113948 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540646 540918 272 0.1
RAM 205128 205128 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574794 575082 288 0.1
RAM 205376 205376 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 658557 658829 272 0.0
RAM 75412 75412 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 678417 678689 272 0.0
RAM 78052 78052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 678417 678689 272 0.0
RAM 78052 78052 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 635341 635613 272 0.0
RAM 70480 70480 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618805 619085 280 0.0
RAM 71652 71652 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638441 638721 280 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638441 638721 280 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 638293 638581 288 0.0
RAM 74660 74660 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 658017 658305 288 0.0
RAM 77204 77204 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 658017 658305 288 0.0
RAM 77204 77204 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614641 614921 280 0.0
RAM 68748 68748 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634501 634781 280 0.0
RAM 71388 71388 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634501 634781 280 0.0
RAM 71388 71388 0 0.0
efr32 lock-app BRD4187C FLASH 939672 939912 240 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 732656 733000 344 0.0
RAM 234828 234828 0 0.0
window-app BRD4187C FLASH 1032104 1032464 360 0.0
RAM 128024 128024 0 0.0
esp32 all-clusters-app c3devkit DRAM 98656 98656 0 0.0
FLASH 1589616 1589874 258 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 117436 117436 0 0.0
FLASH 1556626 1556906 280 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4728 4728 0 0.0
FLASH 2650809 2651649 840 0.0
RAM 111088 111088 0 0.0
all-clusters-app debug unknown 5536 5536 0 0.0
FLASH 5962582 5963432 850 0.0
RAM 514832 514832 0 0.0
all-clusters-minimal-app debug unknown 5432 5432 0 0.0
FLASH 5297294 5298134 840 0.0
RAM 221272 221272 0 0.0
bridge-app debug unknown 5448 5448 0 0.0
FLASH 4649642 4650482 840 0.0
RAM 200144 200144 0 0.0
camera-app debug unknown 5432 5432 0 0.0
FLASH 4672770 4673620 850 0.0
RAM 194592 194592 0 0.0
chip-tool debug unknown 6096 6096 0 0.0
FLASH 13303265 13304211 946 0.0
RAM 603392 603392 0 0.0
chip-tool-ipv6only arm64 unknown 21976 21976 0 0.0
FLASH 11496136 11497048 912 0.0
RAM 656112 656112 0 0.0
fabric-admin debug unknown 5784 5784 0 0.0
FLASH 11568059 11568941 882 0.0
RAM 603176 603176 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4453208 4454048 840 0.0
RAM 187016 187016 0 0.0
fabric-sync debug unknown 4952 4952 0 0.0
FLASH 5570197 5571045 848 0.0
RAM 470400 470400 0 0.0
lighting-app debug+rpc+ui unknown 6160 6160 0 0.0
FLASH 5516481 5516481 0 0.0
RAM 203952 203952 0 0.0
lock-app debug unknown 5400 5400 0 0.0
FLASH 4689458 4690298 840 0.0
RAM 191144 191144 0 0.0
ota-provider-app debug unknown 4736 4736 0 0.0
FLASH 4311670 4312510 840 0.0
RAM 179832 179832 0 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4441990 4442830 840 0.0
RAM 184320 184320 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 2979724 2980572 848 0.0
RAM 144344 144344 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4139160 4139992 832 0.0
RAM 229016 229016 0 0.0
tv-app debug unknown 5728 5728 0 0.0
FLASH 5909045 5909893 848 0.0
RAM 593832 593832 0 0.0
tv-casting-app debug unknown 5304 5304 0 0.0
FLASH 11473757 11474637 880 0.0
RAM 718656 718656 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 911760 912004 244 0.0
RAM 142859 142859 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 902608 902700 92 0.0
RAM 125195 125195 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 850424 850424 0 0.0
RAM 141271 141271 0 0.0
nxp contact k32w0+release FLASH 587080 587192 112 0.0
RAM 70980 70980 0 0.0
mcxw71+release FLASH 601192 601464 272 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 612796 612940 144 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685824 686096 272 0.0
RAM 48584 48584 0 0.0
lock mcxw71+release FLASH 750032 750304 272 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1655684 1656028 344 0.0
RAM 212264 212264 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1562380 1562724 344 0.0
RAM 208560 208560 0 0.0
light cy8ckit_062s2_43012 FLASH 1441180 1441540 360 0.0
RAM 197296 197296 0 0.0
lock cy8ckit_062s2_43012 FLASH 1470068 1470412 344 0.0
RAM 224960 224960 0 0.0
qpg lighting-app qpg6105+debug FLASH 663468 663716 248 0.0
RAM 105156 105156 0 0.0
lock-app qpg6105+debug FLASH 621944 622184 240 0.0
RAM 99768 99768 0 0.0
stm32 light STM32WB5MM-DK FLASH 459840 460080 240 0.1
RAM 141472 141472 0 0.0
telink bridge-app tl7218x FLASH 669192 669336 144 0.0
RAM 90752 90752 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622078 622222 144 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745386 745508 122 0.0
RAM 40396 40396 0 0.0
tl7218x FLASH 753948 754092 144 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 681018 681162 144 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709580 709724 144 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600760 600904 144 0.0
RAM 138812 138812 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 788988 789132 144 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5116 5116 0 0.0
FLASH 1766136 1766760 624 0.0
RAM 93844 93844 0 0.0
chip-tool-ubsan arm unknown 11492 11492 0 0.0
FLASH 18983958 18985294 1336 0.0
RAM 8306328 8306704 376 0.0

bzbarsky-apple
bzbarsky-apple reviewed Feb 26, 2025
View reviewed changes
@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch 2 times, most recently from 1607451 to 20395ef Compare February 26, 2025 23:13
@github-actions GitHub Actions
Copy link

PR #37481: Size comparison from 73fe30c to 20395ef

Full report (1 build for stm32)
platform target config section 73fe30c 20395ef change % change
stm32 light STM32WB5MM-DK FLASH 459840 459848 8 0.0
RAM 141472 141472 0 0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_icd_readclient branch from 20395ef to 951ed7a Compare February 26, 2025 23:27
@yunhanw-google yunhanw-google changed the title [ICD] Re-activate subscription when receiving check-in message if subscription or case timeouts [ICD] Re-activate subscription when receiving check-in message if subscription fails and resub is scheduled Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
app controller core documentation Improvements or additions to documentation examples github integrations lib messaging platform review - pending scripts tests tools workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunhanw-google @bzbarsky-apple @restyled-commits