[Silabs] [WiFi] Removing the IP polling from the siwx917 and adding only for rs9116 #37782
+101
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37782: Size comparison from 629fea4 to 6c979c8 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
|
||
| #if SLI_SI917 | ||
| // Setting the notify since 917 device got the IP already | ||
| WifiPlatformEvent event = WifiPlatformEvent::kStationNotify; |
There was a problem hiding this comment.
the function name is not indicative of the event being posted here.
There was a problem hiding this comment.
I have updated the names, I can even add these 2 in different files if needed
|
PR #37782: Size comparison from 629fea4 to a39d828 Increases above 0.2%:
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
The IP polling is already a part of sl_net_up() in the wifi-sdk so removing the duplicate file and using the file directly from the wifi sdk itself.
Just Keeping the notify connection once connect is done for 917 devices.
Moving the refactored code to the rs9116 where it is only needed.
Modifying the TA retry attempts to 1, i.e., TA will retry to connect only once and then give control to M4, to get best power number
Tested on 917 SOC and RS9116