-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a default gemini config. #37795
Add a default gemini config. #37795
Conversation
This is based on https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github#custom-configuration Disabled the "have fun" and "summary" (as the PR summary should already contain this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @andy31415, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds a default Gemini configuration file (.gemini/config.yaml
) to the repository. The configuration disables the 'have_fun' feature and customizes the code review settings. Specifically, it sets the comment severity threshold to 'MEDIUM', allows unlimited review comments (max_review_comments: -1
), and disables the 'help' and 'summary' features for pull request opening events, while enabling the 'code_review' feature for the same events. This configuration is based on the documentation provided by Google for customizing Gemini behavior in GitHub.
Highlights
- Configuration File Creation: A new file
.gemini/config.yaml
is added to the repository to store the default Gemini configuration. - Feature Disabling: The 'have_fun' feature is disabled in the default configuration.
- Code Review Customization: The code review settings are customized to set a 'MEDIUM' severity threshold, allow unlimited comments, and enable code reviews on pull request opening while disabling help and summary.
Changelog
- .gemini/config.yaml
- Added a new configuration file to disable 'have_fun', set comment severity threshold to 'MEDIUM', allow unlimited review comments, and customize pull request opening event settings.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
YAML is often used for configuration files due to its human-readable format and support for complex data structures.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds a default Gemini configuration file. The configuration disables the 'have fun' and 'summary' features, which aligns with the PR summary already containing this information. The configuration seems reasonable, and I've added a few comments to improve clarity.
Summary of Findings
Assessment
The pull request introduces a default Gemini configuration file, which is a good starting point for customizing Gemini's behavior. The configuration disables "have fun" and "summary" features. I've provided some feedback regarding the configuration values. Please address these comments before merging, and ensure that others review and approve this code before merging.
PR #37795: Size comparison from 6947f9b to 0e474c6 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This is based on https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github#custom-configuration
Disabled the "have fun" and "summary" (as the PR summary should already contain this)
Testing
N/A just a config file