Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shadowing warning #37796

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix shadowing warning #37796

wants to merge 1 commit into from
+2 −2

Conversation

ksperling-apple
Copy link
Contributor

Fix shadowing warning when building Darwin framework tool from #37783 with gn.

Testing

Compiles with gn now.

@ksperling-apple ksperling-apple requested a review from a team as a code owner February 26, 2025 18:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

PR #37796: Size comparison from 391e5a3 to 43faf28

Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 391e5a3 43faf28 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1096892 1096892 0 0.0
RAM 94842 94842 0 0.0
bl702 lighting-app bl702+eth FLASH 651870 651870 0 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 829142 829142 0 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061538 1061538 0 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892382 892382 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975278 975278 0 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 817152 817152 0 0.0
RAM 120272 120272 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 826072 826072 0 0.0
RAM 125368 125368 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772956 772956 0 0.0
RAM 113740 113740 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 757240 757240 0 0.0
RAM 113948 113948 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540646 540646 0 0.0
RAM 205128 205128 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574794 574794 0 0.0
RAM 205376 205376 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 658557 658557 0 0.0
RAM 75412 75412 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 678417 678417 0 0.0
RAM 78052 78052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 678417 678417 0 0.0
RAM 78052 78052 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 635341 635341 0 0.0
RAM 70480 70480 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618805 618805 0 0.0
RAM 71652 71652 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638441 638441 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638441 638441 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 638293 638293 0 0.0
RAM 74660 74660 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 658017 658017 0 0.0
RAM 77204 77204 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 658017 658017 0 0.0
RAM 77204 77204 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614641 614641 0 0.0
RAM 68748 68748 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634501 634501 0 0.0
RAM 71388 71388 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634501 634501 0 0.0
RAM 71388 71388 0 0.0
efr32 lock-app BRD4187C FLASH 939672 939672 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 732656 732656 0 0.0
RAM 234828 234828 0 0.0
window-app BRD4187C FLASH 1032104 1032104 0 0.0
RAM 128024 128024 0 0.0
esp32 all-clusters-app c3devkit DRAM 98656 98656 0 0.0
FLASH 1589616 1589616 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 117436 117436 0 0.0
FLASH 1556626 1556626 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4728 4728 0 0.0
FLASH 2650809 2650809 0 0.0
RAM 111088 111088 0 0.0
all-clusters-app debug unknown 5536 5536 0 0.0
FLASH 5962582 5962582 0 0.0
RAM 514832 514832 0 0.0
all-clusters-minimal-app debug unknown 5432 5432 0 0.0
FLASH 5297294 5297294 0 0.0
RAM 221272 221272 0 0.0
bridge-app debug unknown 5448 5448 0 0.0
FLASH 4649642 4649642 0 0.0
RAM 200144 200144 0 0.0
camera-app debug unknown 5432 5432 0 0.0
FLASH 4672770 4672770 0 0.0
RAM 194592 194592 0 0.0
chip-tool debug unknown 6096 6096 0 0.0
FLASH 13303265 13303265 0 0.0
RAM 603392 603392 0 0.0
chip-tool-ipv6only arm64 unknown 21976 21976 0 0.0
FLASH 11496136 11496136 0 0.0
RAM 656112 656112 0 0.0
fabric-admin debug unknown 5784 5784 0 0.0
FLASH 11568059 11568059 0 0.0
RAM 603176 603176 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4453208 4453208 0 0.0
RAM 187016 187016 0 0.0
fabric-sync debug unknown 4952 4952 0 0.0
FLASH 5570197 5570197 0 0.0
RAM 470400 470400 0 0.0
lighting-app debug+rpc+ui unknown 6160 6160 0 0.0
FLASH 5516481 5516481 0 0.0
RAM 203952 203952 0 0.0
lock-app debug unknown 5400 5400 0 0.0
FLASH 4689458 4689458 0 0.0
RAM 191144 191144 0 0.0
ota-provider-app debug unknown 4736 4736 0 0.0
FLASH 4311670 4311670 0 0.0
RAM 179832 179832 0 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4441990 4441990 0 0.0
RAM 184320 184320 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 2979724 2979724 0 0.0
RAM 144344 144344 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4139160 4139160 0 0.0
RAM 229016 229016 0 0.0
tv-app debug unknown 5728 5728 0 0.0
FLASH 5909045 5909045 0 0.0
RAM 593832 593832 0 0.0
tv-casting-app debug unknown 5304 5304 0 0.0
FLASH 11473757 11473757 0 0.0
RAM 718656 718656 0 0.0
nxp contact k32w0+release FLASH 587080 587080 0 0.0
RAM 70980 70980 0 0.0
mcxw71+release FLASH 601192 601192 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 612796 612796 0 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685824 685824 0 0.0
RAM 48584 48584 0 0.0
lock mcxw71+release FLASH 750032 750032 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1655684 1655684 0 0.0
RAM 212264 212264 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1562380 1562380 0 0.0
RAM 208560 208560 0 0.0
light cy8ckit_062s2_43012 FLASH 1441180 1441180 0 0.0
RAM 197296 197296 0 0.0
lock cy8ckit_062s2_43012 FLASH 1470068 1470068 0 0.0
RAM 224960 224960 0 0.0
qpg lighting-app qpg6105+debug FLASH 663468 663468 0 0.0
RAM 105156 105156 0 0.0
lock-app qpg6105+debug FLASH 621944 621944 0 0.0
RAM 99768 99768 0 0.0
stm32 light STM32WB5MM-DK FLASH 459840 459840 0 0.0
RAM 141472 141472 0 0.0
telink bridge-app tl7218x FLASH 669192 669192 0 0.0
RAM 90752 90752 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622078 622078 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745386 745386 0 0.0
RAM 40396 40396 0 0.0
tl7218x FLASH 753948 753948 0 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 681018 681018 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709580 709580 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600760 600760 0 0.0
RAM 138812 138812 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 788988 788988 0 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5116 5116 0 0.0
FLASH 1766136 1766136 0 0.0
RAM 93844 93844 0 0.0
chip-tool-ubsan arm unknown 11492 11492 0 0.0
FLASH 18983958 18983958 0 0.0
RAM 8306328 8306328 0 0.0

@woody-apple woody-apple added the hotfix urgent fix needed, can bypass review label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@kiel-apple kiel-apple kiel-apple approved these changes

Assignees
No one assigned
Labels
darwin examples fast track hotfix urgent fix needed, can bypass review review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ksperling-apple @andy31415 @woody-apple @kiel-apple