A number of updates and fixes for dockerized CHIP #1947
+2,264
−2,990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauckhart
force-pushed
the
chip-testing-updates
branch
3 times, most recently
from
655668c to
0ec603f
Compare
lauckhart
force-pushed
the
chip-testing-updates
branch
from
0ec603f to
ce83bdb
Compare
* We now pull tests from python files using the method name rather than the filename * Tests with multiple runs now generate as a suite with one test for each run * Tests can specify alternate PICS values * Implemented more flexible PICS configuration that will merge values from files, container files and/or memory * New ".matter-test.properties" configuration file allows for setting dev config such as disabling pulls * We patch the centralized pipe message generator to delay for 20ms after sending a message * Updated various tests; mostly enabling tests that work now but also some renames and disabling of new tests we don't support * RVC tests use CHIP's specialized RVC PICS file * Removed Dockerfile step that was breaking builds and was no longer necessary due to CHIP updates * Added "debug" mode to dockerfile build to show verbose logs and drop into console if build fails * Added script to run command in new ephemeral container * Python test parser now supports arguments with quoted strings and removes arguments that we don't need/want * Fixed loading of PICS for some python scripts * Fix bug in managed arrays when value is null * Fixed matter-run to support execution of scripts outside of build tree * A few PICS updates * We now use a single command pipe for all test apps and ensure correct symlink is installed for each test * The root test descriptor in the container now contains a format version # to prevent container/test harness mismatches * Modernize eslint config * Use docker bake for builds * Create new image for example apps and do not (currently) build by default * Store current CHIP SHA in git so builds are consistent * Enable repo cache for builds * Patch CIPD config to drop installation of many unnecessary gigabytes of stuff * Do not checkout some unnecessary submodules * Do not use pigweed for bootstrapping beyond CIPD * New workflow for building image and running tests * Break CC out into its own test group because it is very slow
lauckhart
force-pushed
the
chip-testing-updates
branch
from
ce83bdb to
d89a270
Compare
Apollon77
approved these changes
May 3, 2025
| node-version: | ||
| description: 'Node.js version' | ||
| required: true | ||
| default: '20.x' |
There was a problem hiding this comment.
upgrade to 22.x as other tests too?
| - cron: 0 3 * * * # Every day at 03:00 | ||
| workflow_dispatch: # Manually on demand | ||
| push: | ||
| branches: [ "main", "chip-testing-updates-dev" ] |
There was a problem hiding this comment.
second branch name should be removed before merging?
| // Exclude because of timing issues with the filesocket/backchannel commands | ||
| "OVENOPSTATE/2.1", | ||
| "OVENOPSTATE/2.2", | ||
|
|
||
| // Excluded because Pause and Resume are unsupported but test python file exists | ||
| // https://github.com/CHIP-Specifications/chip-test-plans/issues/5067 | ||
| "OVENOPSTATE/2.3", |
There was a problem hiding this comment.
You can also remove this exclude because project-chip/connectedhomeip#38430 is soled so these tests disappeared anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now pull tests from python files using the method name rather than the filename
Tests with multiple runs now generate as a suite with one test for each run
Tests can specify alternate PICS values
Implemented more flexible PICS configuration that will merge values from files, container files and/or memory
New ".matter-test.properties" configuration file allows for setting dev config such as disabling pulls
We now pass command pipe messages from the docker container to the test harness via UDP
We patch the centralized pipe message generator to delay for 20ms after sending a message
Updated various tests; mostly enabling tests that work now but also some renames and disabling of new tests we don't support
RVC tests use CHIP's specialized RVC PICS file
Removed Dockerfile step that was breaking builds and was no longer necessary due to CHIP updates
Added "debug" mode to dockerfile build to show verbose logs and drop into console if build fails
Added script to run command in new ephemeral container
Python test parser now supports arguments with quoted strings and removes arguments that we don't need/want
Fixed loading of PICS for some python scripts
Fix bug in managed arrays when value is null
Fixed matter-run to support execution of scripts outside of build tree
A few PICS updates
We now use a single command pipe for all test apps and ensure correct symlink is installed for each test
The root test descriptor in the container now contains a format version # to prevent container/test harness mismatches
Modernize eslint config