Cleaning up the custom xml UI update as well as the custom xml package uploading such that there are no duplicates #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brdandu
commented
Apr 3, 2024
brdandu
commented
- JIRA: ZAPP-1351
|
cluster extensions(attributes, cmd) are not showing up in the UI. Looking into it. |
paulr34
approved these changes
Apr 3, 2024
paulr34
previously approved these changes
Apr 3, 2024
brdandu
force-pushed
the
bug/fixCustomXml/ZAPP-1351
branch
from
38b0216
to
e41829c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1296 +/- ##
==========================================
- Coverage 65.89% 65.89% -0.01%
==========================================
Files 189 189
Lines 20132 20152 +20
Branches 4337 4344 +7
==========================================
+ Hits 13266 13279 +13
- Misses 6866 6873 +7 ☔ View full report in Codecov by Sentry. |
fixed |
|
remaining tasks: Add unit tests for custom xml |
- Cleaning up the custom xml UI update as well as the custom xml package uploading such that there are no duplicates - Fixing the custom xml UI for attributes, commands and events when cluster extensions are added through custom xml. Needed the custom xml package ids to be included - Fixing the duplicate attributes and commands which show up in the attribute and command UI when a custom cluster with custom attributes and commands is added. This is solved by using a set in : reduceAndConcatenateZclEntity(db, id, [...new Set([...standAlonePackageIds, clusterInfo.packageRef])], - Adding unique constraint to Attribute table and adding insert or replace to attribute insert query such that custom cluster extensions are not reloaded into the db. - Making sure the global attributes are part of the custom clusters in static-zcl.js while calling reduceAndConcatenateZclEntity - Making sure that session partition numbering is correct for the partitionNumber column - For loading custom cluster extensions such as attributes and commands. Making sure they are loaded into the database based on the top level zcl package loaded. This is needed for sdk upgrades or custom xml in multi-protocol. See changes to zcl-loader-silabs and zcl-loader - When adding custom xml, there are instances where multiple zcl packages are loaded for the same xml file. This was an issue with the mutation observer. Getting the load new package call out of the observer to fix this. Reproducer: Open zap, add custom xml from extensions, close extensions pane, add another xml from extensions and you will see two instances of the xml added. If you add another xml then you see 3 instances. This is fixed in ZclCustomZclView.vue - Making sure that the delete button appears across custom xml for removal and doing some minor UI cleanup - Add more unit tests for custom xml - JIRA: ZAPP-1351
brdandu
force-pushed
the
bug/fixCustomXml/ZAPP-1351
branch
from
02b5d86
to
b4ae37d
Compare
|
See #1299 PR instead since that has the fix on top of the multi protocol revert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.