Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure getEndpointIds function to pass ui.test.js #1483

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Restructure getEndpointIds function to pass ui.test.js #1483

merged 1 commit into from
Nov 15, 2024

Conversation

ethanzhouyc
Copy link
Collaborator

@ethanzhouyc ethanzhouyc commented Nov 14, 2024 •
edited
Loading

  • call API directly without action
  • check if $serverGet is defined before calling it
  • the change would help Feature Page Phase 2 #1482 pass unit tests and prevent ui.test.js from failing in the future

@ethanzhouyc
restructure getEndpointIds to pass ui.test.js
f7cf986 
- call API directly without action
- check if $serverGet defined before calling it
@ethanzhouyc ethanzhouyc mentioned this pull request Nov 14, 2024
Merged
@ethanzhouyc ethanzhouyc merged commit 24ea807 into project-chip:master Nov 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brdandu brdandu brdandu left review comments

@paulr34 paulr34 paulr34 approved these changes

@tecimovic tecimovic tecimovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethanzhouyc @tecimovic @brdandu @paulr34