Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a condition to to toolbar about q-electron-drag #1487

Conversation

tbrkollar
Copy link
Collaborator

No description provided.

@dhchandw
Copy link
Collaborator

In my opinion we should leave some space between the border of the application and the device type list.
Screenshot 2024-11-21 at 9 43 57 AM

@tbrkollar
Copy link
Collaborator Author

In my opinion we should leave some space between the border of the application and the device type list. Screenshot 2024-11-21 at 9 43 57 AM

It's from Quasar. I don't have a quick fix for this. Unfortunately Setting margin-top: 15px, for example, is only half of the solution. Sometimes the option displays as a dropdown (depending on the number of options). It is the incorrect method because there will be 15 pixels between the input and the dropdown.

@dhchandw
Copy link
Collaborator

In my opinion we should leave some space between the border of the application and the device type list. Screenshot 2024-11-21 at 9 43 57 AM

It's from Quasar. I don't have a quick fix for this. Unfortunately Setting margin-top: 15px, for example, is only half of the solution. Sometimes the option displays as a dropdown (depending on the number of options). It is the incorrect method because there will be 15 pixels between the input and the dropdown.

Can we just always use a dropdown since that looks cleaner.

@tbrkollar
Copy link
Collaborator Author

Can we just always use a dropdown since that looks cleaner.

It's also from Quasar. :) it is depending on the number of options and the window height.
when the space after the input is enough for the options the quasar put the options like a dropdown, if not, put the top of the input.
Maybe, one solution is that we set the max-height on the dropdown list.

@tbrkollar
Copy link
Collaborator Author

Can we just always use a dropdown since that looks cleaner.

It's also from Quasar. :) it is depending on the number of options and the window height. when the space after the input is enough for the options the quasar put the options like a dropdown, if not, put the top of the input. Maybe, one solution is that we set the max-height on the dropdown list.

But this is not this bug; it is an improvement. :)

@tbrkollar tbrkollar merged commit 8a3df83 into project-chip:master Nov 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Cannot select topmost option in device type list when creating an endpoint
4 participants