Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning not displayed when required cluster is diabled #1507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ethanzhouyc
Copy link
Collaborator

GitHub Issue: #1506
JIRA: GHM_ZAP-474

This PR ensures warnings for disabled required clusters are always displayed, regardless of whether ZAP is in Studio. It removes the condition that previously hid warnings when no UI component data was loaded, fixing the related bug.

@ethanzhouyc
Copy link
Collaborator Author

@brdandu The pre-commit hook is generating hundreds of lines of changes in docs/api.md, unrelated to the actual changes made. Same issue occurred in PR #1503. Do you have any insights into what might be causing this?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.54%. Comparing base (30f9298) to head (b3f7bdc).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1507      +/-   ##
==========================================
- Coverage   66.76%   66.54%   -0.23%     
==========================================
  Files         193      194       +1     
  Lines       20999    21709     +710     
  Branches     4614     4800     +186     
==========================================
+ Hits        14020    14446     +426     
- Misses       6979     7263     +284     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants