Auto-Detect kuberay-operator namespace #678
Conversation
Enable auto-detection of the namespace where kuberay-operator is deployed so we can enable network traffic between raycluster namespace and kuberay-operator namespace. Signed-off-by: Saad Zaher <[email protected]>
| @@ -319,6 +327,32 @@ func isMTLSEnabled(cfg *config.KubeRayConfiguration) bool { | |||
| return cfg == nil || ptr.Deref(cfg.MTLSEnabled, true) | |||
| } | |||
|
|
|||
| // getKubeRayOperatorNamespace tries to get the namespace of the KubeRay operator | |||
| func (r *RayClusterReconciler) getKubeRayOperatorNamespace(ctx context.Context) (string, error) { | |||
There was a problem hiding this comment.
do we want to cover this by a small unit test or dyt it's ok?
There was a problem hiding this comment.
the logic should be covered by https://github.com/project-codeflare/codeflare-operator/blob/main/pkg/controllers/raycluster_controller_test.go ?
do you recommend something else?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chipspeak, kryanbeane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chipspeak, kryanbeane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 35e76cb
into
project-codeflare:main
Enable auto-detection of the namespace where
kuberay-operator is deployed so we can enable network traffic between raycluster namespace and kuberay-operator namespace.
Issue link
RHOAIENG-22373
What changes have been made
auot-detect the namespace where kuberay-operator is deployed to enable correct configuration of network policies for ray clusters
Verification steps
Checks