Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings page fit-and-finish #3343

Merged
merged 10 commits into from
Aug 17, 2023
Merged

Settings page fit-and-finish #3343

merged 10 commits into from
Aug 17, 2023

Conversation

dlabrecq
Copy link
Contributor

@dlabrecq dlabrecq commented Aug 16, 2023 •
edited
Loading

Settings page fit-and-finish updates -- reviewed with Natalie and Ben

  • Added toolbar select component for settings source types and status
  • Added toolbar select component for status
  • Added selectClassName for custom toolbar select component
  • Replace WorkLoadType with custom select toolbar component
  • Add custom select support to dataToolbar
  • Update package lock file
  • Fix lint error
  • Fix settings table column alignment
  • Fix pagination
  • Update bulk select page option to include existing selections

https://issues.redhat.com/browse/COST-3307

@dlabrecq dlabrecq changed the title Settings page updates Settings page fit-and-finish Aug 17, 2023
@dlabrecq dlabrecq merged commit 6eab4e5 into project-koku:main Aug 17, 2023
1 check passed
@dlabrecq dlabrecq deleted the settings branch August 17, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dlabrecq