Use --force twice and add --yes in calls to pvremove. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
=======================================
Coverage 66.86% 66.86%
=======================================
Files 16 16
Lines 2161 2161
=======================================
Hits 1445 1445
Misses 520 520
Partials 196 196 ☔ View full report in Codecov by Sentry. |
There was a case we hit where LVM was in a bad state and in order
to remove a PV it wanted you to use --force twice and would *still*
prompt. The LVM in use was from Ubuntu 22.04 (2.03.11).
I'm not able to easily add a test for this because the LVM state
isn't easily created (it included broken state as seen below):
$ pvs
WARNING: PV /dev/sdf5 is marked in use but no VG was found using it.
WARNING: PV /dev/sdf5 might need repairing.
PV VG Fmt Attr PSize PFree
/dev/sdf5 [unknown] lvm2 u-- 150.00g 0
$ lvm pvremove --force --force --verbose --debug /dev/sdf5
WARNING: PV /dev/sdf5 is used by VG <unknown>.
Really WIPE LABELS from physical volume "/dev/sdf5" of
volume group "<unknown>" [y/n]? yes
Accepted input: [y]
WARNING: Wiping physical volume label from /dev/sdf5 of
volume group "<unknown>".
Labels on physical volume "/dev/sdf5" successfully wiped.
Signed-off-by: Scott Moser <[email protected]>
smoser
force-pushed
the
fix/pvremove-double-force-yes
branch
from
4cc87ec to
28bca3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a case we hit where LVM was in a bad state and in order to remove a PV it wanted you to use --force twice and would still prompt. The LVM in use was from Ubuntu 22.04 (2.03.11).
I'm not able to easily add a test for this because the LVM state isn't easily created (it included broken state as seen below):