Add support for smartpqi #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 66.86% 65.78% -1.09%
==========================================
Files 16 17 +1
Lines 2161 2531 +370
==========================================
+ Hits 1445 1665 +220
- Misses 520 667 +147
- Partials 196 199 +3 ☔ View full report in Codecov by Sentry. |
hallyn
reviewed
Feb 12, 2024
hallyn
reviewed
Feb 12, 2024
hallyn
reviewed
Feb 13, 2024
|
Thanks - it looks good to me. Did you want to rebase or merge as is (with or without the 3 error messages updated)? |
I'll address your comment and rebase/squash into 3 commits (and fix the lint error I somehow missed) |
raharper
force-pushed
the
feat/add-raid-controller-interface-v2
branch
from
a9af788 to
eb3501f
Compare
Older golanglint-ci attempted to lint imported modules due to newer golang version (1.20+), moving to 1.56.1 resolves the issue but then made other modules be come much more difficult to deal with. I noticed there are quite a few //nolint: lines throughout the project and instead of continuing to pepper those around, I chose to disable not-useful nagging/hard-to-configure linters. Signed-off-by: Ryan Harper <[email protected]>
Introduce a RAIDController interface to abstract linux/system from having to know which raid controller it is interacting with. This also supports handling a raid interface with multiple controllers. - Update build Makefile target to depend on all go files Signed-off-by: Ryan Harper <[email protected]>
The smartpqi driver for Adaptec/Microsemi RAID controllers uses a cli tool called `arcconf`. Add support modeled after the existing MegaRAID/storcli structures and implement the RAID Controller interface introduced to abstract the specific RAID adapter for the linux system. - Did not implement the Caching mechansim, repeated invocations do not have any significant impact on system, 5 minute timeout seems quite long to wait for RAID device changes which happen immediately after issuing arcconf commands. - Refactored how linux package looks up disks to see if they belong to a RAID adapter to prevent import loops. - Added tests for arcconf for the interface commands parsing output collected from systems with smartpqi driver and card - Added smartpqi to the demo program Signed-off-by: Ryan Harper <[email protected]>
raharper
force-pushed
the
feat/add-raid-controller-interface-v2
branch
from
eb3501f to
eabe011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for smartpqi/arcconf RAID adapters on Linux
The smartpqi driver for Adaptec/Microsemi RAID controllers uses a cli
tool called
arcconf. Add support modeled after the existingMegaRAID/storcli structures and implement the RAID Controller interface
introduced to abstract the specific RAID adapter for the linux system.
Did not implement the Caching mechansim, repeated invocations do not
have any significant impact on system, 5 minute timeout seems quite long
to wait for RAID device changes which happen immediately after issuing
arcconf commands.
Refactored how linux package looks up disks to see if they belong to
a RAID adapter to prevent import loops.
Added tests for arcconf for the interface commands parsing output
collected from systems with smartpqi driver and card
Added smartpqi to the demo program
Signed-off-by: Ryan Harper [email protected]