2023 10 16/net #93
Merged
2023 10 16/net #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raharper
reviewed
Oct 18, 2023
hallyn
force-pushed
the
2023-10-16/net
branch
8 times, most recently
from
82bc473 to
9f0b7d4
Compare
hallyn
force-pushed
the
2023-10-16/net
branch
from
9f0b7d4 to
b43447c
Compare
|
Ah - pkg/provider/kvm.go is hard-coding the port forwarding into the template. We need a generic way to handle this. So 'trust launch vm1 10.0.2.2:5000/machine/zotservice:1.0.0' should be told to pass a port in to the vm's port 80. Marking this PR 'draft' again until we have some fix for that. |
hallyn
force-pushed
the
2023-10-16/net
branch
11 times, most recently
from
b4e914a to
3494823
Compare
hallyn
force-pushed
the
2023-10-16/net
branch
3 times, most recently
from
7c21435 to
8f55ad4
Compare
|
I'd like to merge this, but we have to first remove the hard-coded vm port forward rules from 'trust launch'. So either I need to accept optional yaml as a 'trust launch' argument, or probably i should just edit the vm definition (either after initial definition, or after install and before first run) to add the network definition. |
Closes project-machine#4 Closes project-machine#7 Implement 'mos boot' which activates all services. Implement a 'simple' network type for services, which isolates a service in a netns with a simple veth on the lxcbr0, with specified host ports forwarded into the container. layers/install: add a zot service layer which uses the simple network. Have test/launch.bats test connection to zot in network-namespaced container. update to v0.0.17 bootkit for 4M firmware kvm provider: specify bootindex 'off' for nics add a hidden subcommand to verify an install.yaml github ci - give 'make test' more time Signed-off-by: Serge Hallyn <[email protected]>
hallyn
force-pushed
the
2023-10-16/net
branch
from
573bcac to
0104d80
Compare
raharper
reviewed
Nov 1, 2023
As suggested by Ryan. Signed-off-by: Serge Hallyn <[email protected]>
disable tdp_mmu in kvm enale dump_invalid_vmcs=Y in kvm_intel This appears to be causing (nested) vm crashes Signed-off-by: Serge Hallyn <[email protected]>
Signed-off-by: Serge Hallyn <[email protected]>
hallyn
force-pushed
the
2023-10-16/net
branch
from
0104d80 to
9ac8db3
Compare
|
Ok - I've dropped the hacky network definition from trust launch, so I do think this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.