Support a shared cache for the OCI blobs, used in the LXC OCI template #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I repos Use open_with_external_blobs which adds support for external blobs, added in ocidir-rs [1]. We'll use the latest version of ocidir-rs from github and we'll switch to version 0.4.0 when it gets released. Closes project-machine#131 [1] containers/ocidir-rs#22 Signed-off-by: Ariel Miculas-Trif <[email protected]>
Now that [1] was merged, we can use find_manifest_descriptor_with_tag and remove copy-pasted code from ocidir-rs. [1] containers/ocidir-rs#28 Signed-off-by: Ariel Miculas-Trif <[email protected]>
Now that [1] was merged into ocidir-rs, we can use the new_empty_manifest function and we'll get a valid OCI image with an empty config descriptor. [1] containers/ocidir-rs#31 Signed-off-by: Ariel Miculas-Trif <[email protected]>
The final size of the blobs should be stored in the descriptors instead of the uncompressed size. Make sure we have a valid oci image by calling the fsck function from ocidir-rs. Closes project-machine#55 Signed-off-by: Ariel Miculas-Trif <[email protected]>
tych0
approved these changes
Oct 14, 2024
|
@hallyn I see that Tycho approved this PR, but it shows I still need reviews. Is that because he's not a member of project-machine? |
hallyn
approved these changes
Oct 15, 2024
|
not sure. Can't apparently tell or modify that from the app. Will check from personal laptop later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two main issues:
blobs/sha256directory containers/ocidir-rs#21 for detailsand simplifies the code by using the recent additions from the ocidir-rs repo.