skip macOS codesigning for now

project-slippi · Aug 21, 2023 · 30e466c · 30e466c
1 parent 0db737b
commit 30e466c
Showing 1 changed file with 48 additions and 48 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -313,54 +313,54 @@ jobs:
           mkdir artifact
           FILE_NAME=${{ env.CURR_DATE }}-${{ env.GIT_HASH }}-${{ env.GIT_TAG }}-${{ matrix.artifact_name }}
           echo "FILE_NAME=$FILE_NAME" >> $GITHUB_ENV
-      - name: "Codesign ${{ matrix.build_type}} Dolphin"
-        if: success() && env.CERTIFICATE_MACOS_APPLICATION != null
-        shell: bash
-        working-directory: ${{ github.workspace }}
-        env:
-          CERTIFICATE_MACOS_APPLICATION: ${{ secrets.CERTIFICATE_MACOS_APPLICATION }}
-          CERTIFICATE_MACOS_PASSWORD: ${{ secrets.CERTIFICATE_MACOS_PASSWORD }}
-        run: |
-          chmod +x Tools/load-macos-certs-ci.sh && ./Tools/load-macos-certs-ci.sh
-          mkdir -p ~/private_keys/
-          echo '${{ secrets.APPLE_CONNECT_API_KEY }}' > ~/private_keys/AuthKey_${{ secrets.APPLE_API_KEY_ID }}.p8
-          /usr/bin/codesign -f -s "${{ secrets.APPLE_IDENTITY_HASH }}" --deep --options runtime --entitlements Source\Core\DolphinQt\DolphinEmu.entitlements ./build/Binaries/Slippi_Dolphin.app
-      - name: "Package, Sign and Notarize Netplay Release DMG"
-        if: success() && env.CERTIFICATE_MACOS_APPLICATION != null
-        shell: bash
-        working-directory: ${{ github.workspace }}
-        env:
-          APPLE_API_KEY: ${{ secrets.APPLE_API_KEY_ID }}
-          APPLE_ISSUER_ID: ${{ secrets.APPLE_ISSUER_ID }}
-          CERTIFICATE_MACOS_APPLICATION: ${{ secrets.CERTIFICATE_MACOS_APPLICATION }}
-        run: |
-          rm build/Binaries/traversal_server
-          chmod +x Tools/create-dmg/run.sh 
-          ./Tools/create-dmg/run.sh --no-internet-enable \
-            --volname "Slippi Dolphin Beta Installer" \
-            --volicon "Data/slippi_dmg_icon.icns" \
-            --background "Data/slippi_dmg_background.png" \
-            --text-size 14 \
-            --window-pos 200 120 \
-            --window-size 590 610 \
-            --icon-size 100 \
-            --app-drop-link 440 196 \
-            --icon "Slippi_Dolphin.app" 140 196 \
-            --hide-extension "Slippi_Dolphin.app" \
-            "${{ env.FILE_NAME }}.dmg" \
-            "./build/Binaries/"
-          mv "${{ env.FILE_NAME }}.dmg" artifact/
-      - name: "Sign and Notarize ${{ matrix.build_type }} Release DMG"
-        if: success() && env.CERTIFICATE_MACOS_APPLICATION != null
-        shell: bash
-        working-directory: ${{ github.workspace }}
-        env:
-          APPLE_API_KEY: ${{ secrets.APPLE_API_KEY_ID }}
-          APPLE_ISSUER_ID: ${{ secrets.APPLE_ISSUER_ID }}
-          CERTIFICATE_MACOS_APPLICATION: ${{ secrets.CERTIFICATE_MACOS_APPLICATION }}
-        run: |
-          /usr/bin/codesign -f -s "${{ secrets.APPLE_IDENTITY_HASH }}" --deep --options runtime ./artifact/${{ env.FILE_NAME }}.dmg
-          chmod +x Tools/notarize_netplay.sh && ./Tools/notarize_netplay.sh ./artifact/${{ env.FILE_NAME }}.dmg
+      # - name: "Codesign ${{ matrix.build_type}} Dolphin"
+      #   if: success() && env.CERTIFICATE_MACOS_APPLICATION != null
+      #   shell: bash
+      #   working-directory: ${{ github.workspace }}
+      #   env:
+      #     CERTIFICATE_MACOS_APPLICATION: ${{ secrets.CERTIFICATE_MACOS_APPLICATION }}
+      #     CERTIFICATE_MACOS_PASSWORD: ${{ secrets.CERTIFICATE_MACOS_PASSWORD }}
+      #   run: |
+      #     chmod +x Tools/load-macos-certs-ci.sh && ./Tools/load-macos-certs-ci.sh
+      #     mkdir -p ~/private_keys/
+      #     echo '${{ secrets.APPLE_CONNECT_API_KEY }}' > ~/private_keys/AuthKey_${{ secrets.APPLE_API_KEY_ID }}.p8
+      #     /usr/bin/codesign -f -s "${{ secrets.APPLE_IDENTITY_HASH }}" --deep --options runtime --entitlements Source\Core\DolphinQt\DolphinEmu.entitlements ./build/Binaries/Slippi_Dolphin.app
+      # - name: "Package, Sign and Notarize Netplay Release DMG"
+      #   if: success() && env.CERTIFICATE_MACOS_APPLICATION != null
+      #   shell: bash
+      #   working-directory: ${{ github.workspace }}
+      #   env:
+      #     APPLE_API_KEY: ${{ secrets.APPLE_API_KEY_ID }}
+      #     APPLE_ISSUER_ID: ${{ secrets.APPLE_ISSUER_ID }}
+      #     CERTIFICATE_MACOS_APPLICATION: ${{ secrets.CERTIFICATE_MACOS_APPLICATION }}
+      #   run: |
+      #     rm build/Binaries/traversal_server
+      #     chmod +x Tools/create-dmg/run.sh 
+      #     ./Tools/create-dmg/run.sh --no-internet-enable \
+      #       --volname "Slippi Dolphin Beta Installer" \
+      #       --volicon "Data/slippi_dmg_icon.icns" \
+      #       --background "Data/slippi_dmg_background.png" \
+      #       --text-size 14 \
+      #       --window-pos 200 120 \
+      #       --window-size 590 610 \
+      #       --icon-size 100 \
+      #       --app-drop-link 440 196 \
+      #       --icon "Slippi_Dolphin.app" 140 196 \
+      #       --hide-extension "Slippi_Dolphin.app" \
+      #       "${{ env.FILE_NAME }}.dmg" \
+      #       "./build/Binaries/"
+      #     mv "${{ env.FILE_NAME }}.dmg" artifact/
+      # - name: "Sign and Notarize ${{ matrix.build_type }} Release DMG"
+      #   if: success() && env.CERTIFICATE_MACOS_APPLICATION != null
+      #   shell: bash
+      #   working-directory: ${{ github.workspace }}
+      #   env:
+      #     APPLE_API_KEY: ${{ secrets.APPLE_API_KEY_ID }}
+      #     APPLE_ISSUER_ID: ${{ secrets.APPLE_ISSUER_ID }}
+      #     CERTIFICATE_MACOS_APPLICATION: ${{ secrets.CERTIFICATE_MACOS_APPLICATION }}
+      #   run: |
+      #     /usr/bin/codesign -f -s "${{ secrets.APPLE_IDENTITY_HASH }}" --deep --options runtime ./artifact/${{ env.FILE_NAME }}.dmg
+      #     chmod +x Tools/notarize_netplay.sh && ./Tools/notarize_netplay.sh ./artifact/${{ env.FILE_NAME }}.dmg
       - name: "Publish"
         if: success()
         uses: actions/upload-artifact@v3