Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: sync the substitutions chapter and the stacker file article #54

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

mbshields
Copy link
Contributor

The substitution sections of these two files are now updated and in sync with each other. There is redundancy, but these two documents are likely to be arrived at from different circumstances -- one is part of the user guide and the other is a reference. This should address Issue #51

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit de96fdb into project-stacker:main Apr 12, 2024
3 checks passed
@mbshields mbshields deleted the docs_mishield_subs branch April 15, 2024 22:32

## Substitutions and variables

In the yaml directives, stacker allows variable substitions of several forms. For example, these three substition statements:

$ONE ${{TWO}} ${{THREE:3}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, we missed this part when I updated the stacker.yaml reference - we do not support $ONE anymore, it is OK to have that in the run section but it'll be interpreted as a shell variable by the shell running in the run section.
It will not be treated as a substitution, and if you run stacker build --substitute ONE=1 on this example you will get an error.

please see project-stacker/stacker#612 for my rewritten version of this in the source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants