fix: In Makefile, download zot as ZOT rather than regclient #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a copy/paste error added by my last change to Makefile. Instead of downloading zot to TOOLS_D/bin/zot, we were downloading regclient. Big surprise, regclient binary doesn't work like zot binary. Fix the download url, and also update the ZOT_VERSION to include the 'v' for consistency with REGCLIENT_VERSION and GOLANGCI_LINT_VERSION. Signed-off-by: Scott Moser <[email protected]>
mikemccracken
approved these changes
Sep 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 11.87% 11.89% +0.02%
==========================================
Files 45 40 -5
Lines 5551 5733 +182
==========================================
+ Hits 659 682 +23
- Misses 4775 4929 +154
- Partials 117 122 +5
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a copy/paste error added by my last change to Makefile. Instead of downloading zot to TOOLS_D/bin/zot, we were downloading regclient. Big surprise, regclient binary doesn't work like zot binary.
Fix the download url, and also update the ZOT_VERSION to include the 'v' for consistency with REGCLIENT_VERSION and GOLANGCI_LINT_VERSION.