fix: Improve bind imports, support lower case 'source' in yaml, add go test #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
force-pushed
the
fix/lower-case-bind-source
branch
from
0a8f62e to
be4532d
Compare
|
builds failed, like below. I uploaded #518 and I'm hitting rebuids. |
smoser
force-pushed
the
fix/lower-case-bind-source
branch
2 times, most recently
from
ae64b1b to
49cdd1a
Compare
…o test
Entries stacker.yaml's "binds" are of type Bind.
When imported from yaml, support was present for these three things:
1. ascii art specifying source and dest ("source -> dest")
2. source only ("source")
3. map with 'Source' and 'Dest'.
Support for '3' is dropped, and replaced by map with 'source' and
'dest'. 'Source' and 'Dest' are inconsistent with the rest of stacker.yaml.
Note that importing from json still does support capital letter variants
as the golang json library is case insensitive.
Improvements to the bind yaml and json support generally rely more
heavily on the library to do the lifting.
Signed-off-by: Scott Moser <[email protected]>
smoser
force-pushed
the
fix/lower-case-bind-source
branch
from
49cdd1a to
fe83356
Compare
Codecov Report
@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 13.14% 13.77% +0.62%
==========================================
Files 40 40
Lines 5712 5671 -41
==========================================
+ Hits 751 781 +30
+ Misses 4837 4762 -75
- Partials 124 128 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
smoser
commented
Oct 3, 2023
hallyn
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entries stacker.yaml's "binds" are of type Bind.
When imported from yaml, support was present for these three things:
Support for '3' is dropped, and replaced by map with 'source' and 'dest'. 'Source' and 'Dest' are inconsistent with the rest of stacker.yaml. Note that importing from json still does support capital letter variants as the golang json library is case insensitive.
Improvements to the bind yaml and json support generally rely more heavily on the library to do the lifting.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.