use squashfuse ready notifier if available #519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallyn
force-pushed
the
2023-10-03/sqnotify
branch
from
00fce79 to
eb4b5d2
Compare
|
It's not the prettiest - I'd probably like to factor both the 'wait until ready' paths into separate functions. |
hallyn
force-pushed
the
2023-10-03/sqnotify
branch
from
eb4b5d2 to
12d5b06
Compare
When using squasfuse, check whether it supports -o notifypipe. If it does, then use that instead of our manual checking the mountpoint inode, which is less reliable. Signed-off-by: Serge Hallyn <[email protected]>
hallyn
force-pushed
the
2023-10-03/sqnotify
branch
from
12d5b06 to
bca66cf
Compare
Codecov Report
@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 13.77% 13.64% -0.13%
==========================================
Files 40 40
Lines 5671 5724 +53
==========================================
Hits 781 781
- Misses 4762 4815 +53
Partials 128 128
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
closing in favor of #528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using squasfuse, check whether it supports -o notifypipe. If it does, then use that instead of our manual checking the mountpoint inode, which is less reliable.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.