fix(umoci)!: umoci's copy buffer set to 1 MiB (#531) #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(umoci)!: umoci's copy buffer set to 1 MiB project-stacker/umoci@89a7ea1 Use updated umoci (project-stacker's fork) to use a 1 MiB copy buffer. This change brings stacker inline with compression parameters used in containers/image libraries and makes them compatible. Signed-off-by: Ramkumar Chinchani <[email protected]> * test(gzip): add unit tests for gzip Signed-off-by: Ramkumar Chinchani <[email protected]> --------- Signed-off-by: Ramkumar Chinchani <[email protected]> (cherry picked from commit 589a648) Signed-off-by: Ramkumar Chinchani <[email protected]>
|
I had just done #537 (and then saw that you did this). I'm surprised that your branch could work. the test you added I do not think can pass because it tests that it is using SKOPEO at a certain version, and you're not going to build that version. i think mine should get skopeo built. |
Hm, he didn't add SKPOEO to the make targets so maybe it didn't actually build it? |
Signed-off-by: Ramkumar Chinchani <[email protected]>
|
Do you need to add the build-deps as in Scott's pr? |
Signed-off-by: Ramkumar Chinchani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project-stacker/umoci@89a7ea1
Use updated umoci (project-stacker's fork) to use a 1 MiB copy buffer. This change brings stacker inline with compression parameters used in containers/image libraries and makes them compatible.
(cherry picked from commit 589a648)
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.